Fix progress bar indicator for accessibility.

Fix progress bar indicator for accessibility.

The progress bar was not being read properly by screen readers for the
Mac (VoiceOver).  This gives the screen reader enough information to
do its job.

BUG=370512
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277880

[Pete Williamson, 2014-06-12 20:57:07]

Accessibilty fix for the Mac for screen readers reading progress notifications.

[dewittj, 2014-06-12 21:04:19]

lgtm + a small style question

https://codereview.chromium.org/333643007/diff/1/ui/message_center/cocoa/noti...
File ui/message_center/cocoa/notification_controller.mm (right):

https://codereview.chromium.org/333643007/diff/1/ui/message_center/cocoa/noti...
ui/message_center/cocoa/notification_controller.mm:55:
-(id)accessibilityAttributeValue:(NSString*)attribute {
Depending on how it looked, this may be more readable if you set the value
within the complex if statement and only have one [nsstring stringwithformat]
call

[Robert Sesek, 2014-06-12 21:23:23]

https://codereview.chromium.org/333643007/diff/1/ui/message_center/cocoa/noti...
File ui/message_center/cocoa/notification_controller.mm (right):

https://codereview.chromium.org/333643007/diff/1/ui/message_center/cocoa/noti...
ui/message_center/cocoa/notification_controller.mm:55:
-(id)accessibilityAttributeValue:(NSString*)attribute {
nit: space before ( after the -

https://codereview.chromium.org/333643007/diff/1/ui/message_center/cocoa/noti...
ui/message_center/cocoa/notification_controller.mm:55:
-(id)accessibilityAttributeValue:(NSString*)attribute {
On 2014/06/12 21:04:19, dewittj wrote:
> Depending on how it looked, this may be more readable if you set the value
> within the complex if statement and only have one [nsstring stringwithformat]
> call

+1

[Pete Williamson, 2014-06-17 18:21:36]

Fix CR comments from RSesek and DewittJ

https://codereview.chromium.org/333643007/diff/1/ui/message_center/cocoa/noti...
File ui/message_center/cocoa/notification_controller.mm (right):

https://codereview.chromium.org/333643007/diff/1/ui/message_center/cocoa/noti...
ui/message_center/cocoa/notification_controller.mm:55:
-(id)accessibilityAttributeValue:(NSString*)attribute {
On 2014/06/12 21:04:19, dewittj wrote:
> Depending on how it looked, this may be more readable if you set the value
> within the complex if statement and only have one [nsstring stringwithformat]
> call

Both Done.

[Robert Sesek, 2014-06-17 18:26:43]

LGTM

[Pete Williamson, 2014-06-17 18:27:54]

The CQ bit was checked by petewil@chromium.org

[commit-bot: I haz the power, 2014-06-17 18:29:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/petewil@chromium.org/333643007/20001

[commit-bot: I haz the power, 2014-06-17 22:13:24]

Change committed as 277880