Source/platform/scroll/FramelessScrollView.cpp - Issue 333633003: Fix for select PopupMenuList appearance in rtl mode with overlay-scrollbar enabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/scroll/FramelessScrollView.cpp

Issue 333633003: Fix for select PopupMenuList appearance in rtl mode with overlay-scrollbar enabled (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/scroll/FramelessScrollView.cpp

diff --git a/Source/platform/scroll/FramelessScrollView.cpp b/Source/platform/scroll/FramelessScrollView.cpp

index ce002fefaa49ef8dfc958baef9ebdb8776087644..90a0855b38c152b7b1c29a37c8774a605b9a8944 100644

--- a/Source/platform/scroll/FramelessScrollView.cpp

+++ b/Source/platform/scroll/FramelessScrollView.cpp

@@ -80,7 +80,7 @@ HostWindow* FramelessScrollView::hostWindow() const

IntRect FramelessScrollView::windowClipRect(IncludeScrollbarsInRect scrollbarInclusion) const

{

IntRect clipRect = visibleContentRect(scrollbarInclusion);

- if (shouldPlaceVerticalScrollbarOnLeft() && verticalScrollbar())

+ if (shouldPlaceVerticalScrollbarOnLeft() && verticalScrollbar() && !verticalScrollbar()->isOverlayScrollbar())

clipRect.move(verticalScrollbar()->width(), 0);

return contentsToWindow(clipRect);

}

« no previous file with comments | « no previous file | Source/web/PopupListBox.cpp » ('j') | no next file with comments »