Added split tap to TouchExplorationController

ui/chromeos/touch_exploration_controller.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_CHROMEOS_TOUCH_EXPLORATION_CONTROLLER_H_
 #define UI_CHROMEOS_TOUCH_EXPLORATION_CONTROLLER_H_
 
 #include "base/timer/timer.h"
 #include "base/values.h"
 #include "ui/chromeos/ui_chromeos_export.h"
@@ skipping 87 matching lines @@
   ui::EventRewriteStatus InSingleTapPressed(
       const ui::TouchEvent& event, scoped_ptr<ui::Event>* rewritten_event);
   ui::EventRewriteStatus InSingleTapReleased(
       const ui::TouchEvent& event, scoped_ptr<ui::Event>* rewritten_event);
   ui::EventRewriteStatus InDoubleTapPressed(
       const ui::TouchEvent& event, scoped_ptr<ui::Event>* rewritten_event);
   ui::EventRewriteStatus InTouchExploration(
       const ui::TouchEvent& event, scoped_ptr<ui::Event>* rewritten_event);
   ui::EventRewriteStatus InPassthroughMinusOne(
       const ui::TouchEvent& event, scoped_ptr<ui::Event>* rewritten_event);
-
+  ui::EventRewriteStatus InTESecondPress(

[dmazzoni, 2014/06/13 05:52:38]

TE is too abbreviated for me. How about InTouchExplSecondPress?

[evy, 2014/06/13 16:48:07]

Done.
Should the state name be changed from TE_SECOND_PRESS to
TOUCH_EXPL_SECOND_PRESS?

+      const ui::TouchEvent& event, scoped_ptr<ui::Event>* rewritten_event);
   // This timer is started every time we get the first press event, and
   // it fires after the double-click timeout elapses (300 ms by default).
   // If the user taps and releases within 300 ms and doesn't press again,
   // we treat that as a single mouse move (touch exploration) event.
   void OnTapTimerFired();
 
   // Dispatch a new event outside of the event rewriting flow.
   void DispatchEvent(ui::Event* event);
 
   scoped_ptr<ui::Event> CreateMouseMoveEvent(const gfx::PointF& location,
@@ skipping 33 matching lines @@
 
     // The user placed two or more fingers down within the grace period.
     // We're now in passthrough mode until all fingers are lifted. Initially
     // the first finger is ignored and other fingers are passed through
     // as-is. If a finger other than the initial one is the first to be
     // released, we rewrite the first finger with the touch id of the finger
     // that was released, from now on. The motivation for this is that if
     // the user starts a scroll with 2 fingers, they can release either one
     // and continue the scrolling.
     PASSTHROUGH_MINUS_ONE,
+
+    // The user was in touch exploration, but has placed down another finger

[dmazzoni, 2014/06/13 05:52:38]

Nit: end this sentence with a period.

[evy, 2014/06/13 16:48:08]

Done.

+    // If the user releases the second finger, a click will go through

[dmazzoni, 2014/06/13 05:52:38]

To be entirely accurate, we don't send a click, we send the touch press and
release from the second finger - that may be interpreted as a click, but
sometimes it will be subtly different.

[evy, 2014/06/13 16:48:08]

Done.

+    // at the last touch explore location. If the user releases the touch
+    // explore finger, the other finger will continue with touch explore.
+    // Once more than two fingers are pressed, the state is changed to wait
+    // for all fingers to be released before continuing.
+    TE_SECOND_PRESS,
   };
 
   void VLOGState(int line_number);
 
   void VLOGEvent(const ui::Event& event, int line_number);
 
   // Gets enum name from integer value
   const char* EnumStateToString(State state);
 
   const char* EnumEventTypeToString(ui::EventType type);
@@ skipping 38 matching lines @@
 
   // The previous EventType
   ui::EventType prev_event_;
 
   DISALLOW_COPY_AND_ASSIGN(TouchExplorationController);
 };
 
 }  // namespace ui
 
 #endif  // UI_CHROMEOS_TOUCH_EXPLORATION_CONTROLLER_H_