Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1354)

Unified Diff: chrome/browser/component_updater/cld_component_installer.h

Issue 333603002: Modularize Compact Language Detector 2 (CLD2) data sources (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge https://codereview.chromium.org/326383005 Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chrome_browser_main.cc ('k') | chrome/browser/component_updater/cld_component_installer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/component_updater/cld_component_installer.h
diff --git a/chrome/browser/component_updater/cld_component_installer.h b/chrome/browser/component_updater/cld_component_installer.h
index 9e92c71128d732e6b092583b763bcfa219591835..b226aac872843253a850d655287cfbb1b50c14a5 100644
--- a/chrome/browser/component_updater/cld_component_installer.h
+++ b/chrome/browser/component_updater/cld_component_installer.h
@@ -13,7 +13,7 @@
#include "chrome/browser/component_updater/default_component_installer.h"
namespace test {
-class ScopedCLDDynamicDataHarness;
+class ComponentCldDataHarness;
} // namespace test
namespace component_updater {
@@ -28,7 +28,7 @@ class CldComponentInstallerTraits : public ComponentInstallerTraits {
private:
friend class CldComponentInstallerTest; // For access within SetUp()
- friend class test::ScopedCLDDynamicDataHarness; // For browser tests only
+ friend class test::ComponentCldDataHarness; // For browser tests only
FRIEND_TEST_ALL_PREFIXES(CldComponentInstallerTest, ComponentReady);
FRIEND_TEST_ALL_PREFIXES(CldComponentInstallerTest, GetBaseDirectory);
FRIEND_TEST_ALL_PREFIXES(CldComponentInstallerTest, GetHash);
@@ -53,7 +53,13 @@ class CldComponentInstallerTraits : public ComponentInstallerTraits {
virtual std::string GetName() const OVERRIDE;
static base::FilePath GetInstalledPath(const base::FilePath& base);
+
+ // Sets the path to the CLD data file. Called internally once a valid CLD
+ // data file has been observed. The implementation of this method is
+ // responsible for configuring the CLD data source.
+ // This method is threadsafe.
static void SetLatestCldDataFile(const base::FilePath& path);
+
DISALLOW_COPY_AND_ASSIGN(CldComponentInstallerTraits);
};
@@ -61,11 +67,6 @@ class CldComponentInstallerTraits : public ComponentInstallerTraits {
// the CLD component.
void RegisterCldComponent(ComponentUpdateService* cus);
-// Returns the path to the latest CLD data file into the specified path object,
-// or an empty path if the CLD data file has not been observed yet.
-// This function is threadsafe.
-base::FilePath GetLatestCldDataFile();
-
} // namespace component_updater
#endif // CHROME_BROWSER_COMPONENT_UPDATER_CLD_COMPONENT_INSTALLER_H_
« no previous file with comments | « chrome/browser/chrome_browser_main.cc ('k') | chrome/browser/component_updater/cld_component_installer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698