Modularize Compact Language Detector 2 (CLD2) data sources

chrome/common/chrome_constants.h

Index: chrome/common/chrome_constants.h
diff --git a/chrome/common/chrome_constants.h b/chrome/common/chrome_constants.h
index 4b796f18623cab1982f9cc21b8032f3e39c675e9..1238c6ac1283f867c67f7a4a702350b27391a54a 100644
--- a/chrome/common/chrome_constants.h
+++ b/chrome/common/chrome_constants.h
@@ -59,7 +59,6 @@ extern const base::FilePath::CharType kArchivedHistoryFilename[];
 extern const base::FilePath::CharType kCacheDirname[];
 extern const base::FilePath::CharType kCookieFilename[];
 extern const base::FilePath::CharType kCRLSetFilename[];
-extern const base::FilePath::CharType kCLDDataFilename[];

[Takashi Toyoshima, 2014/06/23 08:50:01]

Just a note for future CLs.
Now this CL is too big, +1386 lines, -709 lines, and contains too many files.
Personally speaking, it would be better to split this kind of independent
cleanups into a separate CL for effective reviews.

[Andrew Hayden (chromium.org), 2014/06/23 13:20:36]

It has become a very large code review because of the expansion into unit tests
and browser tests, which both required nontrivial changes and bloated the review
significantly. Unfortunately there isn't a good way around it, since we need the
unit tests and browser tests functioning in-sync with the code.

I think the real size issue here comes from the fact that we ended up putting
all the code into /components/translate at the same time as refactoring the
access pattern. That's made a lot of changes necessary, like inverting control
in the cld_component_installer and slurping things out of /chrome/common into
/components/translate/content/common.

I do try to keep the size down, but in this case I'm not sure what we could have
done to really decrease the complexity :(

 extern const base::FilePath::CharType kCustomDictionaryFileName[];
 extern const base::FilePath::CharType kExtensionActivityLogFilename[];
 extern const base::FilePath::CharType kExtensionsCookieFilename[];