Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1403)

Issue 3336019: [Isolates] Make isolate tests pass on x64 (Closed)

Created:
10 years, 3 months ago by yurys
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

[Isolates] Make isolate tests pass on x64 * Instead of calling Space::identity() on deleted Space object store a pointer to the identity in the ChunkInfo so that it can be accessed even if the space has been destroyed. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=5464

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M src/spaces.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/spaces.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/spaces-inl.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
yurys
10 years, 3 months ago (2010-09-10 19:38:57 UTC) #1
Dmitry Titov
10 years, 3 months ago (2010-09-10 20:05:41 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698