Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 333593003: Make panels have their own shelf item in Unity (Closed)

Created:
6 years, 6 months ago by pkotwicz
Modified:
6 years, 6 months ago
Reviewers:
Elliot Glaysher, jianli
CC:
chromium-reviews, tfarina, jennb, jianli, Dmitry Titov, dcheng
Project:
chromium
Visibility:
Public.

Description

Make panels have their own shelf item in Unity. This has the side effect of MOSTLY resolving the issue of panels always getting focus when Chrome is activated via Alt+Tab irrespective of which Chrome window was last activate. - Docked "Hangouts" panels will no longer steal focus when the Chrome/browser shelf item is activated via Alt+Tab - Docked "Hangouts" panels will steal focus when the "Hangouts" shelf item is activated via Alt+Tab. In particular, if there is a docked "Hangouts" panel, the docked panel will be activated by Alt+Tab even if there is a detached "Hangouts" panel which was more recently active. BUG=371621 TEST=Manual, see bug Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278804

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/browser/ui/views/panels/panel_view.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
pkotwicz
Elliot, can you please take a look before I send the CL off to a ...
6 years, 6 months ago (2014-06-19 03:57:39 UTC) #1
Elliot Glaysher
lgtm
6 years, 6 months ago (2014-06-19 17:26:46 UTC) #2
pkotwicz
jianli@ for OWNERS
6 years, 6 months ago (2014-06-19 19:56:57 UTC) #3
jianli
lgtm
6 years, 6 months ago (2014-06-19 22:01:16 UTC) #4
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 6 months ago (2014-06-19 22:03:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/333593003/20001
6 years, 6 months ago (2014-06-19 22:04:56 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-20 03:06:58 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-20 03:17:37 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/85763)
6 years, 6 months ago (2014-06-20 03:17:38 UTC) #9
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 6 months ago (2014-06-20 14:17:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/333593003/20001
6 years, 6 months ago (2014-06-20 14:18:49 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-20 14:21:21 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-20 14:28:54 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/85952)
6 years, 6 months ago (2014-06-20 14:28:55 UTC) #14
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 6 months ago (2014-06-20 18:51:03 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/333593003/20001
6 years, 6 months ago (2014-06-20 19:03:48 UTC) #16
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 19:54:29 UTC) #17
Message was sent while issue was closed.
Change committed as 278804

Powered by Google App Engine
This is Rietveld 408576698