Issue 333593002: Oilpan: Prepare to move FormSubmission to Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 333593002: Oilpan: Prepare to move FormSubmission to Oilpan heap. (Closed)

Created:
6 years, 6 months ago by tkent

Modified:
6 years, 6 months ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, gavinp+loader_chromium.org, Nate Chapin

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Oilpan: Prepare to move FormSubmission to Oilpan heap. This removes two Persistent<>s, and add one Persistent<>. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175990

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -17 lines)			Patch
M	Source/core/html/HTMLFormElement.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/html/HTMLFormElement.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/loader/FormSubmission.h	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	Source/core/loader/FormSubmission.cpp	View	3 chunks	+10 lines, -4 lines	0 comments	Download
M	Source/core/loader/NavigationScheduler.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/loader/NavigationScheduler.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 6 (0 generated)

tkent

Note: We can't move NavigationScheduler easily now because NavigationScheduler is a part object of LocalFrame.

6 years, 6 months ago (2014-06-12 02:36:32 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/333593002/1

6 years, 6 months ago (2014-06-12 02:40:07 UTC) #5

Message was sent while issue was closed.

Change committed as 175990