Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issue 333533002: Check File snapshots and Blob byte counts when writing to IDB (Closed)

Created:
6 years, 6 months ago by ericu
Modified:
6 years, 6 months ago
Reviewers:
jsbell, cmumford
CC:
chromium-reviews, jam, alecflett, ericu+idb_chromium.org, darin-cc_chromium.org, cmumford, dgrogan, jsbell+idb_chromium.org
Visibility:
Public.

Description

Check File snapshots and Blob byte counts when writing to IDB. This also fixes a few bugs in the IDB/Blob stuff: * Removed a DCHECK that could hit depending on test teardown order. * Made ChainedBlobWriterImpl truly asynchronous, fixing a crash if a File write failed before the first Blob write was attempted. * Fix a crash where we'd try to free a scoped_ptr twice in the event of an abort. Note that most of the time we won't actually receive File metadata, as Files often aren't snapshotted; I've got a blink change in progress [https://codereview.chromium.org/325383002/] that will always send it. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278509

Patch Set 1 #

Patch Set 2 : Checkpointing work #

Patch Set 3 : Working #

Patch Set 4 : Make ChainedBlobWriterImpl truly asynch; make timestamp check approximate. #

Patch Set 5 : Fix merge conflicts #

Patch Set 6 : Build fix #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -25 lines) Patch
M content/browser/indexed_db/indexed_db_active_blob_registry.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store.h View 1 2 3 4 3 chunks +10 lines, -2 lines 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store.cc View 1 2 3 4 5 9 chunks +45 lines, -20 lines 2 comments Download
M content/browser/indexed_db/indexed_db_dispatcher_host.cc View 1 2 3 4 1 chunk +5 lines, -0 lines 2 comments Download
M content/child/indexed_db/indexed_db_dispatcher.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
ericu
6 years, 6 months ago (2014-06-18 22:46:24 UTC) #1
jsbell
lgtm (but cmumford should take a look too) https://codereview.chromium.org/333533002/diff/100001/content/browser/indexed_db/indexed_db_backing_store.cc File content/browser/indexed_db/indexed_db_backing_store.cc (right): https://codereview.chromium.org/333533002/diff/100001/content/browser/indexed_db/indexed_db_backing_store.cc#newcode2329 content/browser/indexed_db/indexed_db_backing_store.cc:2329: // ...
6 years, 6 months ago (2014-06-18 23:26:10 UTC) #2
ericu
https://codereview.chromium.org/333533002/diff/100001/content/browser/indexed_db/indexed_db_backing_store.cc File content/browser/indexed_db/indexed_db_backing_store.cc (right): https://codereview.chromium.org/333533002/diff/100001/content/browser/indexed_db/indexed_db_backing_store.cc#newcode2329 content/browser/indexed_db/indexed_db_backing_store.cc:2329: // The round-trip can be lossy; round to nearest ...
6 years, 6 months ago (2014-06-18 23:28:44 UTC) #3
ericu
On 2014/06/18 23:28:44, ericu wrote: > https://codereview.chromium.org/333533002/diff/100001/content/browser/indexed_db/indexed_db_backing_store.cc > File content/browser/indexed_db/indexed_db_backing_store.cc (right): > > https://codereview.chromium.org/333533002/diff/100001/content/browser/indexed_db/indexed_db_backing_store.cc#newcode2329 > ...
6 years, 6 months ago (2014-06-19 18:47:15 UTC) #4
cmumford
lgtm https://codereview.chromium.org/333533002/diff/100001/content/browser/indexed_db/indexed_db_dispatcher_host.cc File content/browser/indexed_db/indexed_db_dispatcher_host.cc (right): https://codereview.chromium.org/333533002/diff/100001/content/browser/indexed_db/indexed_db_dispatcher_host.cc#newcode653 content/browser/indexed_db/indexed_db_dispatcher_host.cc:653: if (info.size != static_cast<uint64_t>(-1)) { Just curious why ...
6 years, 6 months ago (2014-06-19 19:37:54 UTC) #5
ericu
https://codereview.chromium.org/333533002/diff/100001/content/browser/indexed_db/indexed_db_dispatcher_host.cc File content/browser/indexed_db/indexed_db_dispatcher_host.cc (right): https://codereview.chromium.org/333533002/diff/100001/content/browser/indexed_db/indexed_db_dispatcher_host.cc#newcode653 content/browser/indexed_db/indexed_db_dispatcher_host.cc:653: if (info.size != static_cast<uint64_t>(-1)) { On 2014/06/19 19:37:54, cmumford ...
6 years, 6 months ago (2014-06-19 21:00:04 UTC) #6
ericu
The CQ bit was checked by ericu@chromium.org
6 years, 6 months ago (2014-06-19 21:00:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericu@chromium.org/333533002/100001
6 years, 6 months ago (2014-06-19 21:02:19 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 22:30:17 UTC) #9
Message was sent while issue was closed.
Change committed as 278509

Powered by Google App Engine
This is Rietveld 408576698