Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 33353002: Add option to download reference build from internal storage. (Closed)

Created:
7 years, 2 months ago by shadi
Modified:
7 years, 1 month ago
Reviewers:
jschuh, tonyg
CC:
chromium-reviews
Visibility:
Public.

Description

Add option to download reference build from internal storage. The Google storage is not always up-to-date with official build. This CL downloads official builds by default from internal storage (requires corp) net. Added --gs option to download from gs://. BUG=302065 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231165

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use goto link instead of corp url #

Patch Set 3 : Fix svn ignored file extensions #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -31 lines) Patch
M tools/update_reference_build.py View 1 2 11 chunks +57 lines, -31 lines 1 comment Download

Messages

Total messages: 11 (0 generated)
shadi
Tony, it appears the gs:// bucket is not updated frequently. I was not able to ...
7 years, 2 months ago (2013-10-21 18:35:59 UTC) #1
tonyg
https://codereview.chromium.org/33353002/diff/1/tools/update_reference_build.py File tools/update_reference_build.py (right): https://codereview.chromium.org/33353002/diff/1/tools/update_reference_build.py#newcode43 tools/update_reference_build.py:43: 'official_builds/%s/%s/%s') I'm not sure we should check in a ...
7 years, 2 months ago (2013-10-21 19:20:05 UTC) #2
shadi
PTAL https://codereview.chromium.org/33353002/diff/1/tools/update_reference_build.py File tools/update_reference_build.py (right): https://codereview.chromium.org/33353002/diff/1/tools/update_reference_build.py#newcode43 tools/update_reference_build.py:43: 'official_builds/%s/%s/%s') On 2013/10/21 19:20:06, tonyg wrote: > I'm ...
7 years, 2 months ago (2013-10-21 19:53:53 UTC) #3
shadi
PTAL https://codereview.chromium.org/33353002/diff/90001/tools/update_reference_build.py File tools/update_reference_build.py (right): https://codereview.chromium.org/33353002/diff/90001/tools/update_reference_build.py#newcode44 tools/update_reference_build.py:44: 'official_builds/%s/%s/%s') I was not able to bypass login ...
7 years, 2 months ago (2013-10-23 22:41:35 UTC) #4
tonyg
Justin, is it okay to check in this URL? Any ideas for avoiding it? The ...
7 years, 2 months ago (2013-10-23 23:16:56 UTC) #5
jschuh
On 2013/10/23 23:16:56, tonyg wrote: > Justin, is it okay to check in this URL? ...
7 years, 2 months ago (2013-10-23 23:34:37 UTC) #6
jschuh
On 2013/10/23 23:34:37, Justin Schuh wrote: > On 2013/10/23 23:16:56, tonyg wrote: > > Justin, ...
7 years, 2 months ago (2013-10-24 00:07:47 UTC) #7
shadi
On 2013/10/24 00:07:47, Justin Schuh wrote: > On 2013/10/23 23:34:37, Justin Schuh wrote: > > ...
7 years, 1 month ago (2013-10-25 21:36:15 UTC) #8
tonyg
lgtm
7 years, 1 month ago (2013-10-25 22:12:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shadi@chromium.org/33353002/90001
7 years, 1 month ago (2013-10-26 00:24:01 UTC) #10
commit-bot: I haz the power
7 years, 1 month ago (2013-10-26 00:28:40 UTC) #11
Message was sent while issue was closed.
Change committed as 231165

Powered by Google App Engine
This is Rietveld 408576698