Make the migrated ChromeVox work.

Make the migrated ChromeVox work.

This sets the COMPILED flag in base.js to true when compressing the
javascript sources. ChromeVox makes assumptions about what content
script files to load (which it could get from the manifest) and also
does initialization differently depending on thsi flag.  Leaving cleanup
of that to later CLs if we want to do that in the interest of changing
as little as possible during the migration.

BUG=371692
R=dtseng@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277956

[Peter Lundblad, 2014-06-11 23:11:41]

This fixes the compiled compressed version. Uncompressed is still not working,
let's address that when we create a manifest for it.

[David Tseng, 2014-06-12 20:23:30]

https://codereview.chromium.org/333503002/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/chromevox/tools/jsbundler.py (right):

https://codereview.chromium.org/333503002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/tools/jsbundler.py:180: Returns:
'sources, dict' looks like a pair so perhaps remove ', dict'. Also, more useful
to say '... path string as keys, SourceWithPath objects as values

https://codereview.chromium.org/333503002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/tools/jsbundler.py:210: '''Sets
COMPILED to true in the Closure base.js source.'''
nit: Args?

https://codereview.chromium.org/333503002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/tools/jsbundler.py:218:
Die('COMPILED var assignment not found in %s' % base.GetInPath())
Print the count since technically it could be > 1

https://codereview.chromium.org/333503002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/tools/jsbundler.py:306:
path_rewriter = PathRewriter(options.prefix_map)
Maybe call this need_source_text?

[chromium-reviews, 2014-06-16 22:41:07]

PTAL

dtseng@chromium.org writes:
> 
> 
> 
> 
>
https://codereview.chromium.org/333503002/diff/1/chrome/browser/resources/chr...
> File chrome/browser/resources/chromeos/chromevox/tools/jsbundler.py
> (right):
> 
>
https://codereview.chromium.org/333503002/diff/1/chrome/browser/resources/chr...
> chrome/browser/resources/chromeos/chromevox/tools/jsbundler.py:180:
> Returns:
> 'sources, dict' looks like a pair so perhaps remove ', dict'. Also, more
> useful to say '... path string as keys, SourceWithPath objects as values

Reworded.

>
https://codereview.chromium.org/333503002/diff/1/chrome/browser/resources/chr...
> chrome/browser/resources/chromeos/chromevox/tools/jsbundler.py:210:
> '''Sets COMPILED to true in the Closure base.js source.'''
> nit: Args?

Done.

>
https://codereview.chromium.org/333503002/diff/1/chrome/browser/resources/chr...
> chrome/browser/resources/chromeos/chromevox/tools/jsbundler.py:218:
> Die('COMPILED var assignment not found in %s' % base.GetInPath())
> Print the count since technically it could be > 1

I don't think it can given the count=1 in the call above.

>
https://codereview.chromium.org/333503002/diff/1/chrome/browser/resources/chr...
> chrome/browser/resources/chromeos/chromevox/tools/jsbundler.py:306:
> path_rewriter = PathRewriter(options.prefix_map)
> Maybe call this need_source_text?

Changed to a less confusing name.

> https://codereview.chromium.org/333503002/

-- 

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[David Tseng, 2014-06-16 23:03:23]

lgtm


On Mon, Jun 16, 2014 at 3:41 PM, 'Peter Nilsson Lundblad' via
Chromium-reviews <chromium-reviews@chromium.org> wrote:

> PTAL
>
> dtseng@chromium.org writes:
> >
> >
> >
> >
> >
>
https://codereview.chromium.org/333503002/diff/1/chrome/browser/resources/chr...
> > File chrome/browser/resources/chromeos/chromevox/tools/jsbundler.py
> > (right):
> >
> >
>
https://codereview.chromium.org/333503002/diff/1/chrome/browser/resources/chr...
> > chrome/browser/resources/chromeos/chromevox/tools/jsbundler.py:180:
> > Returns:
> > 'sources, dict' looks like a pair so perhaps remove ', dict'. Also, more
> > useful to say '... path string as keys, SourceWithPath objects as values
>
> Reworded.
>
> >
>
https://codereview.chromium.org/333503002/diff/1/chrome/browser/resources/chr...
> > chrome/browser/resources/chromeos/chromevox/tools/jsbundler.py:210:
> > '''Sets COMPILED to true in the Closure base.js source.'''
> > nit: Args?
>
> Done.
>
> >
>
https://codereview.chromium.org/333503002/diff/1/chrome/browser/resources/chr...
> > chrome/browser/resources/chromeos/chromevox/tools/jsbundler.py:218:
> > Die('COMPILED var assignment not found in %s' % base.GetInPath())
> > Print the count since technically it could be > 1
>
> I don't think it can given the count=1 in the call above.
>
> >
>
https://codereview.chromium.org/333503002/diff/1/chrome/browser/resources/chr...
> > chrome/browser/resources/chromeos/chromevox/tools/jsbundler.py:306:
> > path_rewriter = PathRewriter(options.prefix_map)
> > Maybe call this need_source_text?
>
> Changed to a less confusing name.
>
> > https://codereview.chromium.org/333503002/
>
> --
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Peter Lundblad, 2014-06-17 02:29:06]

The CQ bit was checked by plundblad@chromium.org

[Peter Lundblad, 2014-06-17 02:29:14]

The CQ bit was checked by plundblad@chromium.org

[commit-bot: I haz the power, 2014-06-17 02:30:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/plundblad@chromium.org/333503002/40001

[commit-bot: I haz the power, 2014-06-17 02:30:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-17 02:30:03]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[David Tseng, 2014-06-17 03:18:29]

lgtm

[Peter Lundblad, 2014-06-17 21:14:25]

The CQ bit was checked by plundblad@chromium.org

[commit-bot: I haz the power, 2014-06-17 21:15:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/plundblad@chromium.org/333503002/40001

[commit-bot: I haz the power, 2014-06-18 06:51:43]

Change committed as 277956