Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 333493002: Load the default favicon as a native image, rather than as a Skia image. (Closed)

Created:
6 years, 6 months ago by Ilya Sherman
Modified:
6 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, markusheintz_, jam, android-webview-reviews_chromium.org
Visibility:
Public.

Description

Load the default favicon as a native image, rather than as a Skia image. This silences a line of log spew that's generated on every launch of a local debug build. BUG=none TEST=less log spew R=rsesek@chromium.org TBR=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276787

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -17 lines) Patch
M android_webview/browser/aw_content_browser_client.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/aw_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/cookies_tree_model.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/search_engines/template_url_table_model.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Ilya Sherman
6 years, 6 months ago (2014-06-11 22:59:48 UTC) #1
Robert Sesek
LGTM, because log_spew-- is good. It would be better if this resource were passed around ...
6 years, 6 months ago (2014-06-12 13:51:03 UTC) #2
mkosiba (inactive)
android_webview rslgtm
6 years, 6 months ago (2014-06-12 15:35:32 UTC) #3
Ilya Sherman
TBR jam for straightforward content/ and chrome/ changes.
6 years, 6 months ago (2014-06-12 17:02:28 UTC) #4
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 6 months ago (2014-06-12 17:02:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/333493002/1
6 years, 6 months ago (2014-06-12 17:03:09 UTC) #6
jam
lgtm
6 years, 6 months ago (2014-06-12 18:27:06 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 20:27:47 UTC) #8
Message was sent while issue was closed.
Change committed as 276787

Powered by Google App Engine
This is Rietveld 408576698