Add a CFRunLoop mode for message loop tasks

Add a CFRunLoop mode for message loop tasks

This can be used to construct nested CFRunLoops that are restricted to
the MessageLoop tasks.

BUG=314190
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276856

[ccameron, 2014-06-11 23:04:34]

If this looks good to you for the base/ stuff, I can send wider to the OWNERs.

[Robert Sesek, 2014-06-12 13:45:51]

Yes, this looks about right.

The only thing I'd change is to move the constant from being a static member of
MessagePumpMac to be just an extern in the base:: namespace. It's seems a bit of
a mismatch for MessagePumpMac because callers don't use the constant with a
MessagePump object (though it is used internally). Callers will instead run
their own run loop/"message pump" with this constant.

[ccameron, 2014-06-12 16:01:08]

Thanks -- updated, and adding thakis for base/ review.

[Robert Sesek, 2014-06-12 16:02:26]

On 2014/06/12 16:01:08, ccameron1 wrote:
> Thanks -- updated, and adding thakis for base/ review.

This should be reviewed by Mark, who wrote the MessagePump in the first place.

[Mark Mentovai, 2014-06-12 16:17:13]

https://codereview.chromium.org/333473002/diff/40001/base/message_loop/messag...
File base/message_loop/message_pump_mac.mm (right):

https://codereview.chromium.org/333473002/diff/40001/base/message_loop/messag...
base/message_loop/message_pump_mac.mm:340: CFRunLoopAddTimer(run_loop_,
delayed_work_timer_,
There’s enough duplication now that I think we should have wrappers for
CFRunLoop{Add,Remove}{Timer,Source,Observer}(). Here in this code, you would
just call the wrappers. The wrappers would call the real function twice, once
for each run loop mode that we’re interested in.

[ccameron, 2014-06-12 17:10:40]

https://codereview.chromium.org/333473002/diff/40001/base/message_loop/messag...
File base/message_loop/message_pump_mac.mm (right):

https://codereview.chromium.org/333473002/diff/40001/base/message_loop/messag...
base/message_loop/message_pump_mac.mm:340: CFRunLoopAddTimer(run_loop_,
delayed_work_timer_,
On 2014/06/12 16:17:13, Mark Mentovai wrote:
> There’s enough duplication now that I think we should have wrappers for
> CFRunLoop{Add,Remove}{Timer,Source,Observer}(). Here in this code, you would
> just call the wrappers. The wrappers would call the real function twice, once
> for each run loop mode that we’re interested in.

Yeah, I was on the bubble about which way to go -- I've changed them over to
CFRunLoop*To/FromAllModes

[Mark Mentovai, 2014-06-12 17:42:22]

Yup, I think this way’s cleaner. LGTM.

[ccameron, 2014-06-12 18:51:48]

Thanks!

[ccameron, 2014-06-12 18:51:53]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2014-06-12 18:53:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ccameron@chromium.org/333473002/60001

[commit-bot: I haz the power, 2014-06-12 23:57:57]

Change committed as 276856