[CSS Grid Layout] Implement 'justify-items' parsing

Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl

 {% from 'macros.tmpl' import license %}
 {#
     This file is for property handlers which use the templating engine to
     reduce (handwritten) code duplication.
 
     The `properties' dict can be used to access a property's parameters in
     jinja2 templates (i.e. setter, getter, initial, type_name)
 #}
 #include "config.h"
 #include "StyleBuilderFunctions.h"
@@ skipping 544 matching lines @@
 
 {% macro apply_alignment(property_id, alignment_type) %}
 {{declare_value_function(property_id)}}
 {
     CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);
     if (Pair* pairValue = primitiveValue->getPairValue()) {
         state.style()->set{{alignment_type}}(*pairValue->first());
         state.style()->set{{alignment_type}}OverflowAlignment(*pairValue->second());
     } else {
         state.style()->set{{alignment_type}}(*primitiveValue);
-        // FIXME: We should clear the overflow-alignment mode here and probably

[Timothy Loh, 2014/07/01 12:44:51]

I'm not sure why you've removed this FIXME, isn't the behaviour still incorrect?
If you specify inherit for one of these properties, and your parent has used a
pair and set the overflow-alignment mode, then won't we fail to inherit the
overflow-alignment mode, since we use default initial/inherit handlers? You can
see the current behaviour for initial/inherit in the generated file
StyleBuilderFunctions.cpp.

[jfernandez, 2014/07/01 20:54:27]

I added cases in the layout tests to verify it was working as defined in the
specs, but you are right, it's not working as expected in the case of "inherit"
keyword. It works fine for the "initial", at least, regarding the Computed
Value. I think the FIXME still applies in the case of the Used Value. 

I'm preparing a new patch resolving these issues, according to the deleted FIXME
comment. 

-        // also set it in the initial and inherit handlers
     }
 }
 {% endmacro %}
 {{apply_alignment('CSSPropertyJustifySelf', 'JustifySelf')}}
 {{apply_alignment('CSSPropertyAlignItems', 'AlignItems')}}
 {{apply_alignment('CSSPropertyAlignSelf', 'AlignSelf')}}
 
+{% macro apply_alignment_with_legacy_keyword(property_id, alignment_type) %}
+{{declare_value_function(property_id)}}
+{
+    CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);
+    if (Pair* pairValue = primitiveValue->getPairValue()) {
+        if (pairValue->first()->getValueID() == CSSValueLegacy) {
+            state.style()->set{{alignment_type}}PositionType(LegacyPosition);
+            state.style()->set{{alignment_type}}(*pairValue->second());
+        } else {
+            state.style()->set{{alignment_type}}(*pairValue->first());
+            state.style()->set{{alignment_type}}OverflowAlignment(*pairValue->second());
+        }
+    } else {
+        state.style()->set{{alignment_type}}(*primitiveValue);
+    }
+}
+{% endmacro %}
+{{apply_alignment_with_legacy_keyword('CSSPropertyJustifyItems', 'JustifyItems')}}

[Timothy Loh, 2014/07/01 12:44:51]

If you're only going to have a single property with this application rule, you
should probably put the logic in StyleBuilderCustom instead. I understand that
there's a few places where the logic can end up, and writing some documentation
on the right way to do this is on my todo list.

[jfernandez, 2014/07/01 20:54:27]

I thought that "align-items" would eventually be allowed to use the "legacy", I
still have to clarify that with the specs editor. But you are right that for the
time being, this function is better defined in the StyleBuilderCustom. Ill cook
a new patch to do so.

+
 {% macro apply_svg_paint(property_id, paint_type) %}
 {% set property = properties[property_id] %}
 {{declare_initial_function(property_id)}}
 {
     {{set_value(property)}}(
         SVGRenderStyle::initial{{paint_type}}Type(),
         SVGRenderStyle::initial{{paint_type}}Color(),
         SVGRenderStyle::initial{{paint_type}}Uri(),
         state.applyPropertyToRegularStyle(),
         state.applyPropertyToVisitedLinkStyle());
@@ skipping 26 matching lines @@
             color,
             svgPaint->uri(),
             state.applyPropertyToRegularStyle(),
             state.applyPropertyToVisitedLinkStyle());
     }
 }
 {% endmacro %}
 {{apply_svg_paint('CSSPropertyFill', 'FillPaint')}}
 {{apply_svg_paint('CSSPropertyStroke', 'StrokePaint')}}
 } // namespace WebCore