[CSS Grid Layout] Implement 'justify-items' parsing

Source/core/css/parser/CSSPropertyParser.cpp

 /*
  * Copyright (C) 2003 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
  * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved.
  * Copyright (C) 2012 Intel Corporation. All rights reserved.
  *
@@ skipping 1181 matching lines @@
             return true;
         }
         return false;
     }
 
     case CSSPropertyJustifySelf:
         if (!RuntimeEnabledFeatures::cssGridLayoutEnabled())
             return false;
 
         return parseItemPositionOverflowPosition(propId, important);
+
+    case CSSPropertyJustifyItems:
+        if (!RuntimeEnabledFeatures::cssGridLayoutEnabled())
+            return false;
+
+        return parseLegacyPosition(propId, important) || parseItemPositionOverflowPosition(propId, important);
+
     case CSSPropertyGridAutoColumns:
     case CSSPropertyGridAutoRows:
         if (!RuntimeEnabledFeatures::cssGridLayoutEnabled())
             return false;
         parsedValue = parseGridTrackSize(*m_valueList);
         break;
 
     case CSSPropertyGridTemplateColumns:
     case CSSPropertyGridTemplateRows:
         if (!RuntimeEnabledFeatures::cssGridLayoutEnabled())
@@ skipping 2914 matching lines @@
     return shape;
 }
 
 static bool isItemPositionKeyword(CSSValueID id)
 {
     return id == CSSValueStart || id == CSSValueEnd || id == CSSValueCenter
         || id == CSSValueSelfStart || id == CSSValueSelfEnd || id == CSSValueFlexStart
         || id == CSSValueFlexEnd || id == CSSValueLeft || id == CSSValueRight;
 }
 
+bool CSSPropertyParser::parseLegacyPosition(CSSPropertyID propId, bool important)
+{
+    // [ legacy && [ left | right | center ]
+
+    CSSParserValue* value = m_valueList->current();
+    if (value->id != CSSValueLegacy || !m_valueList->next())
+        return false;
+
+    if (value->id == CSSValueCenter || value->id == CSSValueLeft || value->id == CSSValueRight) {

[cbiesinger, 2014/06/17 22:53:33]

Don't you need an m_valueList->current() call / keep around the next() return
value?

[jfernandez, 2014/06/19 15:19:14]

Done.

+        addProperty(propId, cssValuePool().createIdentifierValue(value->id), important);
+    }

[cbiesinger, 2014/06/17 22:53:33]

else return false?

[jfernandez, 2014/06/19 15:19:14]

Done.

+
+    return true;

[cbiesinger, 2014/06/17 22:53:33]

Also, I'm not 100% sure but I think you need an "if m_valueList->next() return
false;" here.

[jfernandez, 2014/06/19 15:19:14]

Done.

+}
+
 bool CSSPropertyParser::parseItemPositionOverflowPosition(CSSPropertyID propId, bool important)
 {
     // auto | baseline | stretch | [<item-position> && <overflow-position>? ]
     // <item-position> = center | start | end | self-start | self-end | flex-start | flex-end | left | right;
     // <overflow-position> = true | safe
 
     CSSParserValue* value = m_valueList->current();
 
     if (value->id == CSSValueAuto || value->id == CSSValueBaseline || value->id == CSSValueStretch) {
         if (m_valueList->next())
@@ skipping 4271 matching lines @@
         parsedValues->append(CSSPrimitiveValue::createIdentifier(CSSValueFill));
     if (!seenStroke)
         parsedValues->append(CSSPrimitiveValue::createIdentifier(CSSValueStroke));
     if (!seenMarkers)
         parsedValues->append(CSSPrimitiveValue::createIdentifier(CSSValueMarkers));
 
     return parsedValues.release();
 }
 
 } // namespace WebCore