Issue 333413006: Prepare SVGElement references in Document for oilpan

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 333413006: Prepare SVGElement references in Document for oilpan (Closed)

Created:
6 years, 6 months ago by kouhei (in TOK)

Modified:
6 years, 6 months ago

Reviewers:
haraken, oilpan-reviews, tkent

CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Prepare SVGElement references in Document for oilpan BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176267

Patch Set 2 : add missing > #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -7 lines)			Patch
	M	Source/core/dom/Document.h	View		1 chunk	+2 lines, -2 lines	1 comment	Download
	M	Source/core/dom/Document.cpp	View	1	3 chunks	+6 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/333413006/20001

6 years, 6 months ago (2014-06-17 01:07:53 UTC) #4

haraken

LGTM https://codereview.chromium.org/333413006/diff/20001/Source/core/dom/Document.h File Source/core/dom/Document.h (right): https://codereview.chromium.org/333413006/diff/20001/Source/core/dom/Document.h#newcode1417 Source/core/dom/Document.h:1417: WillBeHeapHashSet<RawPtrWillBeMember<Element> > m_layerUpdateSVGFilterElements; These elements are guaranteed to ...

6 years, 6 months ago (2014-06-17 01:09:29 UTC) #5

Message was sent while issue was closed.

Change committed as 176267

Expand Messages | Collapse Messages

Issue 333413006: Prepare SVGElement references in Document for oilpan (Closed)

Description

Patch Set 1 #

Patch Set 2 : add missing > #

Messages