Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6725)

Unified Diff: components/omaha_query_params/omaha_query_params.cc

Issue 333353005: Move OmahaQueryParams to a component and add a delegate interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omaha_query_params/omaha_query_params.cc
diff --git a/chrome/browser/omaha_query_params/omaha_query_params.cc b/components/omaha_query_params/omaha_query_params.cc
similarity index 65%
rename from chrome/browser/omaha_query_params/omaha_query_params.cc
rename to components/omaha_query_params/omaha_query_params.cc
index df4e6048fcce804e99dc4f30c18dc4891934b2a6..b04116dbc45513fd6eec45aa13018525376218ef 100644
--- a/chrome/browser/omaha_query_params/omaha_query_params.cc
+++ b/components/omaha_query_params/omaha_query_params.cc
@@ -2,13 +2,15 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/browser/omaha_query_params/omaha_query_params.h"
+#include "components/omaha_query_params/omaha_query_params.h"
#include "base/compiler_specific.h"
+#include "base/logging.h"
#include "base/strings/stringprintf.h"
#include "base/win/windows_version.h"
-#include "chrome/browser/browser_process.h"
-#include "chrome/common/chrome_version_info.h"
+#include "components/omaha_query_params/omaha_query_params_delegate.h"
+
+namespace omaha_query_params {
namespace {
@@ -50,43 +52,34 @@ const char kArch[] =
const char kChrome[] = "chrome";
-const char kStable[] = "stable";
-const char kBeta[] = "beta";
-const char kDev[] = "dev";
-const char kCanary[] = "canary";
-
#if defined(GOOGLE_CHROME_BUILD)
const char kChromeCrx[] = "chromecrx";
#else
const char kChromiumCrx[] = "chromiumcrx";
#endif // defined(GOOGLE_CHROME_BUILD)
-} // namespace
+OmahaQueryParamsDelegate* g_delegate = NULL;
-namespace chrome {
+} // namespace
// static
std::string OmahaQueryParams::Get(ProdId prod) {
return base::StringPrintf(
- "os=%s&arch=%s&nacl_arch=%s&prod=%s&prodchannel=%s"
- "&prodversion=%s&lang=%s",
+ "os=%s&arch=%s&nacl_arch=%s&prod=%s%s",
kOs,
kArch,
GetNaclArch(),
GetProdIdString(prod),
- GetChannelString(),
- chrome::VersionInfo().Version().c_str(),
- GetLang());
+ g_delegate ? g_delegate->GetExtraParams().c_str() : "");
}
// static
-const char* OmahaQueryParams::GetProdIdString(
- chrome::OmahaQueryParams::ProdId prod) {
+const char* OmahaQueryParams::GetProdIdString(OmahaQueryParams::ProdId prod) {
switch (prod) {
- case chrome::OmahaQueryParams::CHROME:
+ case OmahaQueryParams::CHROME:
return kChrome;
break;
- case chrome::OmahaQueryParams::CRX:
+ case OmahaQueryParams::CRX:
#if defined(GOOGLE_CHROME_BUILD)
return kChromeCrx;
#else
@@ -132,29 +125,10 @@ const char* OmahaQueryParams::GetNaclArch() {
#endif
}
-const char* OmahaQueryParams::GetChannelString() {
- switch (chrome::VersionInfo::GetChannel()) {
- case chrome::VersionInfo::CHANNEL_STABLE:
- return kStable;
- break;
- case chrome::VersionInfo::CHANNEL_BETA:
- return kBeta;
- break;
- case chrome::VersionInfo::CHANNEL_DEV:
- return kDev;
- break;
- case chrome::VersionInfo::CHANNEL_CANARY:
- return kCanary;
- break;
- case chrome::VersionInfo::CHANNEL_UNKNOWN:
- return kUnknown;
- break;
- }
- return kUnknown;
-}
-
-const char* OmahaQueryParams::GetLang() {
- return g_browser_process->GetApplicationLocale().c_str();
+// static
+void OmahaQueryParams::SetDelegate(OmahaQueryParamsDelegate* delegate) {
+ DCHECK(!g_delegate || !delegate);
+ g_delegate = delegate;
}
-} // namespace chrome
+} // namespace omaha_query_params
« no previous file with comments | « components/omaha_query_params/omaha_query_params.h ('k') | components/omaha_query_params/omaha_query_params_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698