chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc - Issue 333353005: Move OmahaQueryParams to a component and add a delegate interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc

Issue 333353005: Move OmahaQueryParams to a component and add a delegate interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/pnacl/pnacl_component_installer.cc ('k') | chrome/browser/extensions/updater/extension_updater_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc

diff --git a/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc b/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc

index 9af060053e9e1bc43adc4b3349f05f726029ce47..bc743e98da9645fc6797a137a6c64454c54dfcbc 100644

--- a/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc

+++ b/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc

@@ -12,11 +12,11 @@

#include "chrome/browser/extensions/extension_warning_service.h"

#include "chrome/browser/extensions/extension_warning_set.h"

#include "chrome/browser/extensions/updater/extension_updater.h"

-#include "chrome/browser/omaha_query_params/omaha_query_params.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser_finder.h"

#include "chrome/browser/ui/browser_navigator.h"

#include "chrome/browser/ui/browser_window.h"

+#include "components/omaha_query_params/omaha_query_params.h"

#include "content/public/browser/notification_service.h"

#include "extensions/browser/extension_system.h"

#include "extensions/common/api/runtime.h"

@@ -183,7 +183,7 @@ void ChromeRuntimeAPIDelegate::OpenURL(const GURL& uninstall_url) {

}

bool ChromeRuntimeAPIDelegate::GetPlatformInfo(PlatformInfo* info) {

- const char* os = chrome::OmahaQueryParams::GetOS();

+ const char* os = omaha_query_params::OmahaQueryParams::GetOS();

if (strcmp(os, "mac") == 0) {

info->os = PlatformInfo::OS_MAC_;

} else if (strcmp(os, "win") == 0) {

@@ -201,7 +201,7 @@ bool ChromeRuntimeAPIDelegate::GetPlatformInfo(PlatformInfo* info) {

return false;

}

- const char* arch = chrome::OmahaQueryParams::GetArch();

+ const char* arch = omaha_query_params::OmahaQueryParams::GetArch();

if (strcmp(arch, "arm") == 0) {

info->arch = PlatformInfo::ARCH_ARM;

} else if (strcmp(arch, "x86") == 0) {

@@ -213,7 +213,7 @@ bool ChromeRuntimeAPIDelegate::GetPlatformInfo(PlatformInfo* info) {

return false;

}

- const char* nacl_arch = chrome::OmahaQueryParams::GetNaclArch();

+ const char* nacl_arch = omaha_query_params::OmahaQueryParams::GetNaclArch();

if (strcmp(nacl_arch, "arm") == 0) {

info->nacl_arch = PlatformInfo::NACL_ARCH_ARM;

} else if (strcmp(nacl_arch, "x86-32") == 0) {