Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4493)

Unified Diff: chrome/browser/omaha_query_params/omaha_query_params_unittest.cc

Issue 333353005: Move OmahaQueryParams to a component and add a delegate interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/omaha_query_params/omaha_query_params_unittest.cc
diff --git a/chrome/browser/omaha_query_params/omaha_query_params_unittest.cc b/chrome/browser/omaha_query_params/omaha_query_params_unittest.cc
deleted file mode 100644
index e8a736aea300f7aabd1d7b11b1b791037f0b6c58..0000000000000000000000000000000000000000
--- a/chrome/browser/omaha_query_params/omaha_query_params_unittest.cc
+++ /dev/null
@@ -1,49 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/omaha_query_params/omaha_query_params.h"
-
-#include "base/strings/stringprintf.h"
-#include "chrome/common/chrome_version_info.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-using base::StringPrintf;
-
-namespace chrome {
-
-bool Contains(const std::string& source, const std::string& target) {
- return source.find(target) != std::string::npos;
-}
-
-void TestParams(OmahaQueryParams::ProdId prod_id) {
- std::string params = OmahaQueryParams::Get(prod_id);
-
- // This doesn't so much test what the values are (since that would be an
- // almost exact duplication of code with omaha_query_params.cc, and wouldn't
- // really test anything) as it is a verification that all the params are
- // present in the generated string.
- EXPECT_TRUE(
- Contains(params, StringPrintf("os=%s", OmahaQueryParams::GetOS())));
- EXPECT_TRUE(
- Contains(params, StringPrintf("arch=%s", OmahaQueryParams::GetArch())));
- EXPECT_TRUE(Contains(
- params,
- StringPrintf("prod=%s", OmahaQueryParams::GetProdIdString(prod_id))));
- EXPECT_TRUE(Contains(
- params,
- StringPrintf("prodchannel=%s", OmahaQueryParams::GetChannelString())));
- EXPECT_TRUE(Contains(
- params,
- StringPrintf("prodversion=%s", chrome::VersionInfo().Version().c_str())));
- EXPECT_TRUE(Contains(
- params,
- StringPrintf("lang=%s", OmahaQueryParams::GetLang())));
-}
-
-TEST(OmahaQueryParams, GetOmahaQueryParams) {
- TestParams(OmahaQueryParams::CRX);
- TestParams(OmahaQueryParams::CHROME);
-}
-
-} // namespace chrome
« no previous file with comments | « chrome/browser/omaha_query_params/omaha_query_params.cc ('k') | chrome/browser/ui/webui/app_list/start_page_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698