Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Side by Side Diff: chrome/browser/extensions/webstore_installer_unittest.cc

Issue 333353005: Move OmahaQueryParams to a component and add a delegate interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/strings/stringprintf.h" 7 #include "base/strings/stringprintf.h"
8 #include "chrome/browser/extensions/webstore_installer.h" 8 #include "chrome/browser/extensions/webstore_installer.h"
9 #include "chrome/browser/omaha_query_params/omaha_query_params.h" 9 #include "chrome/browser/omaha_query_params/chrome_omaha_query_params_delegate.h "
10 #include "components/omaha_query_params/omaha_query_params.h"
10 #include "extensions/common/id_util.h" 11 #include "extensions/common/id_util.h"
11 #include "net/base/escape.h" 12 #include "net/base/escape.h"
12 #include "testing/gtest/include/gtest/gtest.h" 13 #include "testing/gtest/include/gtest/gtest.h"
13 14
14 using base::StringPrintf; 15 using base::StringPrintf;
15 using chrome::OmahaQueryParams; 16 using omaha_query_params::OmahaQueryParams;
16 17
17 namespace extensions { 18 namespace extensions {
18 19
19 // Returns true if |target| is found in |source|. 20 // Returns true if |target| is found in |source|.
20 bool Contains(const std::string& source, const std::string& target) { 21 bool Contains(const std::string& source, const std::string& target) {
21 return source.find(target) != std::string::npos; 22 return source.find(target) != std::string::npos;
22 } 23 }
23 24
24 TEST(WebstoreInstallerTest, PlatformParams) { 25 TEST(WebstoreInstallerTest, PlatformParams) {
25 std::string id = extensions::id_util::GenerateId("some random string"); 26 std::string id = extensions::id_util::GenerateId("some random string");
26 std::string source = "inline"; 27 std::string source = "inline";
27 GURL url = WebstoreInstaller::GetWebstoreInstallURL(id, 28 GURL url = WebstoreInstaller::GetWebstoreInstallURL(id,
28 WebstoreInstaller::INSTALL_SOURCE_INLINE); 29 WebstoreInstaller::INSTALL_SOURCE_INLINE);
29 std::string query = url.query(); 30 std::string query = url.query();
30 EXPECT_TRUE( 31 EXPECT_TRUE(
31 Contains(query, StringPrintf("os=%s", OmahaQueryParams::GetOS()))); 32 Contains(query, StringPrintf("os=%s", OmahaQueryParams::GetOS())));
32 EXPECT_TRUE( 33 EXPECT_TRUE(
33 Contains(query, StringPrintf("arch=%s", OmahaQueryParams::GetArch()))); 34 Contains(query, StringPrintf("arch=%s", OmahaQueryParams::GetArch())));
34 EXPECT_TRUE(Contains( 35 EXPECT_TRUE(Contains(
35 query, StringPrintf("nacl_arch=%s", OmahaQueryParams::GetNaclArch()))); 36 query, StringPrintf("nacl_arch=%s", OmahaQueryParams::GetNaclArch())));
36 EXPECT_TRUE( 37 EXPECT_TRUE(
37 Contains(query, 38 Contains(query,
38 net::EscapeQueryParamValue( 39 net::EscapeQueryParamValue(
39 StringPrintf("installsource=%s", source.c_str()), true))); 40 StringPrintf("installsource=%s", source.c_str()), true)));
40 EXPECT_TRUE( 41 EXPECT_TRUE(Contains(
41 Contains(query, StringPrintf("lang=%s", OmahaQueryParams::GetLang()))); 42 query,
43 StringPrintf("lang=%s", ChromeOmahaQueryParamsDelegate::GetLang())));
42 } 44 }
43 45
44 } // namespace extensions 46 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698