Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: chrome/browser/extensions/updater/manifest_fetch_data.cc

Issue 333353005: Move OmahaQueryParams to a component and add a delegate interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/updater/manifest_fetch_data.h" 5 #include "chrome/browser/extensions/updater/manifest_fetch_data.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/metrics/histogram.h" 10 #include "base/metrics/histogram.h"
11 #include "base/strings/string_number_conversions.h" 11 #include "base/strings/string_number_conversions.h"
12 #include "base/strings/string_util.h" 12 #include "base/strings/string_util.h"
13 #include "chrome/browser/google/google_brand.h" 13 #include "chrome/browser/google/google_brand.h"
14 #include "chrome/browser/metrics/chrome_metrics_service_accessor.h" 14 #include "chrome/browser/metrics/chrome_metrics_service_accessor.h"
15 #include "chrome/browser/omaha_query_params/omaha_query_params.h" 15 #include "components/omaha_query_params/omaha_query_params.h"
16 #include "net/base/escape.h" 16 #include "net/base/escape.h"
17 17
18 namespace { 18 namespace {
19 19
20 // Maximum length of an extension manifest update check url, since it is a GET 20 // Maximum length of an extension manifest update check url, since it is a GET
21 // request. We want to stay under 2K because of proxies, etc. 21 // request. We want to stay under 2K because of proxies, etc.
22 const int kExtensionsManifestMaxURLSize = 2000; 22 const int kExtensionsManifestMaxURLSize = 2000;
23 23
24 } // namespace 24 } // namespace
25 25
26 namespace extensions { 26 namespace extensions {
27 27
28 ManifestFetchData::ManifestFetchData(const GURL& update_url, int request_id) 28 ManifestFetchData::ManifestFetchData(const GURL& update_url, int request_id)
29 : base_url_(update_url), 29 : base_url_(update_url),
30 full_url_(update_url) { 30 full_url_(update_url) {
31 std::string query = full_url_.has_query() ? 31 std::string query = full_url_.has_query() ?
32 full_url_.query() + "&" : std::string(); 32 full_url_.query() + "&" : std::string();
33 query += chrome::OmahaQueryParams::Get(chrome::OmahaQueryParams::CRX); 33 query += omaha_query_params::OmahaQueryParams::Get(
34 omaha_query_params::OmahaQueryParams::CRX);
34 GURL::Replacements replacements; 35 GURL::Replacements replacements;
35 replacements.SetQueryStr(query); 36 replacements.SetQueryStr(query);
36 full_url_ = full_url_.ReplaceComponents(replacements); 37 full_url_ = full_url_.ReplaceComponents(replacements);
37 38
38 request_ids_.insert(request_id); 39 request_ids_.insert(request_id);
39 } 40 }
40 41
41 ManifestFetchData::~ManifestFetchData() {} 42 ManifestFetchData::~ManifestFetchData() {}
42 43
43 // The format for request parameters in update checks is: 44 // The format for request parameters in update checks is:
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 NOTREACHED(); 157 NOTREACHED();
157 return value == kNeverPinged || value > 0; 158 return value == kNeverPinged || value > 0;
158 } 159 }
159 160
160 void ManifestFetchData::Merge(const ManifestFetchData& other) { 161 void ManifestFetchData::Merge(const ManifestFetchData& other) {
161 DCHECK(full_url() == other.full_url()); 162 DCHECK(full_url() == other.full_url());
162 request_ids_.insert(other.request_ids_.begin(), other.request_ids_.end()); 163 request_ids_.insert(other.request_ids_.begin(), other.request_ids_.end());
163 } 164 }
164 165
165 } // namespace extensions 166 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/updater/extension_updater_unittest.cc ('k') | chrome/browser/extensions/webstore_installer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698