Issue 333353002: Teach Ninja generator about 'AR.host' specified in 'make_global_settings'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 333353002: Teach Ninja generator about 'AR.host' specified in 'make_global_settings'. (Closed)

Created:
6 years, 6 months ago by yukawa

Modified:
6 years, 6 months ago

Reviewers:
scottmg

CC:
gyp-developer_googlegroups.com, Torne, Ami GONE FROM CHROMIUM

Base URL:
http://gyp.googlecode.com/svn/trunk

Visibility:
Public.

Teach Ninja generator about 'AR.host' specified in 'make_global_settings'. With this CL, Ninja generator starts recognizing 'AR.host' specified in 'make_global_settings', like Make generator. BUG=gyp:434 TEST=unittest R=scottmg@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1942

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	pylib/gyp/generator/ninja.py	View		3 chunks	+4 lines, -1 line	0 comments	Download
	M	test/make_global_settings/ar/gyptest-make_global_settings_ar.py	View		1 chunk	+1 line, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

yukawa

Hi Scott. This is 'AR.host' version. Can you take a look? Thanks!

6 years, 6 months ago (2014-06-16 16:56:32 UTC) #1

yukawa

6 years, 6 months ago (2014-06-16 17:38:13 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r1942 (presubmit successful).