Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 333333002: DevTools: Instrument DOMWindowEventQueue for async stacks. (Closed)

Created:
6 years, 6 months ago by aandrey
Modified:
6 years, 6 months ago
Reviewers:
pfeldman, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Instrument DOMWindowEventQueue for async stacks. This adds async stacks support for the following DOM events: - hashchange - selectionchange - pointerlockchange and others - securitypolicyviolation - storage BUG=272416 R=yurys, pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176352

Patch Set 1 #

Total comments: 4

Patch Set 2 : addressed #

Total comments: 1

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -8 lines) Patch
A LayoutTests/inspector/sources/debugger/async-callstack-events.html View 1 chunk +69 lines, -0 lines 0 comments Download
A LayoutTests/inspector/sources/debugger/async-callstack-events-expected.txt View 1 chunk +18 lines, -0 lines 0 comments Download
M Source/core/dom/ScriptedAnimationController.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/DOMWindowEventQueue.cpp View 1 5 chunks +12 lines, -1 line 0 comments Download
M Source/core/inspector/AsyncCallStackTracker.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/AsyncCallStackTracker.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerEventQueue.cpp View 1 4 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
aandrey
6 years, 6 months ago (2014-06-16 15:01:37 UTC) #1
yurys
https://codereview.chromium.org/333333002/diff/1/Source/core/events/DOMWindowEventQueue.cpp File Source/core/events/DOMWindowEventQueue.cpp (right): https://codereview.chromium.org/333333002/diff/1/Source/core/events/DOMWindowEventQueue.cpp#newcode97 Source/core/events/DOMWindowEventQueue.cpp:97: InspectorInstrumentation::didDispatchEvent(event->target(), event); Don't we need to distinguish cancel operation ...
6 years, 6 months ago (2014-06-17 07:34:26 UTC) #2
aandrey
Also added same instrumentation for worker event queue. PTAL. https://codereview.chromium.org/333333002/diff/1/Source/core/events/DOMWindowEventQueue.cpp File Source/core/events/DOMWindowEventQueue.cpp (right): https://codereview.chromium.org/333333002/diff/1/Source/core/events/DOMWindowEventQueue.cpp#newcode97 Source/core/events/DOMWindowEventQueue.cpp:97: ...
6 years, 6 months ago (2014-06-17 10:34:18 UTC) #3
yurys
lgtm https://codereview.chromium.org/333333002/diff/20001/Source/core/workers/WorkerEventQueue.cpp File Source/core/workers/WorkerEventQueue.cpp (right): https://codereview.chromium.org/333333002/diff/20001/Source/core/workers/WorkerEventQueue.cpp#newcode117 Source/core/workers/WorkerEventQueue.cpp:117: InspectorInstrumentation::didEnqueueEvent(event->target(), event.get()); Would be nice to have a ...
6 years, 6 months ago (2014-06-17 11:22:14 UTC) #4
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 6 months ago (2014-06-17 11:41:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/333333002/40001
6 years, 6 months ago (2014-06-17 11:42:02 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-17 13:58:30 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/18048)
6 years, 6 months ago (2014-06-17 13:58:30 UTC) #8
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 6 months ago (2014-06-17 13:58:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/333333002/40001
6 years, 6 months ago (2014-06-17 13:59:54 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-17 15:00:31 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/18109)
6 years, 6 months ago (2014-06-17 15:00:32 UTC) #12
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 6 months ago (2014-06-17 21:01:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/333333002/40001
6 years, 6 months ago (2014-06-17 21:02:19 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 21:02:50 UTC) #15
Message was sent while issue was closed.
Change committed as 176352

Powered by Google App Engine
This is Rietveld 408576698