Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Unified Diff: chrome/browser/metrics/variations/variations_service.h

Issue 333313003: Simulate variation seeds using installed version string. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/metrics/variations/variations_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/variations/variations_service.h
===================================================================
--- chrome/browser/metrics/variations/variations_service.h (revision 277860)
+++ chrome/browser/metrics/variations/variations_service.h (working copy)
@@ -10,7 +10,9 @@
#include "base/compiler_specific.h"
#include "base/gtest_prod_util.h"
#include "base/memory/scoped_ptr.h"
+#include "base/memory/weak_ptr.h"
#include "base/metrics/field_trial.h"
+#include "base/task_runner_util.h"
Ilya Sherman 2014/06/18 17:11:36 nit: Does this need to be in the header file, or c
Alexei Svitkine (slow) 2014/06/18 17:17:17 Oops, meant to add it to the .cc file, but I guess
#include "base/time/time.h"
#include "chrome/browser/metrics/variations/variations_request_scheduler.h"
#include "chrome/browser/metrics/variations/variations_seed_store.h"
@@ -26,14 +28,18 @@
class PrefService;
class PrefRegistrySimple;
-namespace user_prefs {
-class PrefRegistrySyncable;
+namespace base {
+class Version;
}
namespace metrics {
class MetricsStateManager;
}
+namespace user_prefs {
+class PrefRegistrySyncable;
+}
+
namespace chrome_variations {
class VariationsSeed;
@@ -145,6 +151,11 @@
// ResourceRequestAllowedNotifier::Observer implementation:
virtual void OnResourceRequestsAllowed() OVERRIDE;
+ // Performs a variations seed simulation with the given |seed| and |version|
+ // and logs the simulation results as histograms.
+ void PerformSimulationWithVersion(scoped_ptr<VariationsSeed> seed,
+ const base::Version& version);
+
// Record the time of the most recent successful fetch.
void RecordLastFetchTime();
@@ -193,6 +204,8 @@
VariationsRegistrySyncer registry_syncer_;
#endif
+ base::WeakPtrFactory<VariationsService> weak_ptr_factory_;
+
DISALLOW_COPY_AND_ASSIGN(VariationsService);
};
« no previous file with comments | « no previous file | chrome/browser/metrics/variations/variations_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698