generate GetAttribLocation/GetUniformLocation by build_gles2_cmd_buffer.py

gpu/command_buffer/build_gles2_cmd_buffer.py

Index: gpu/command_buffer/build_gles2_cmd_buffer.py
diff --git a/gpu/command_buffer/build_gles2_cmd_buffer.py b/gpu/command_buffer/build_gles2_cmd_buffer.py
index 1c7b0199371cf8732b1335d8db811af47c840545..e8b5fe3abf297c74ea90b1154a9065f4564687e7 100755
--- a/gpu/command_buffer/build_gles2_cmd_buffer.py
+++ b/gpu/command_buffer/build_gles2_cmd_buffer.py
@@ -1708,10 +1708,10 @@ _FUNCTION_INFO = {
     'result': ['SizedResult<GLuint>'],
   },
   'GetAttribLocation': {
-    'type': 'HandWritten',
-    'needs_size': True,
+    'type': 'Custom',
     'cmd_args':
-        'GLidProgram program, const char* name, NonImmediate GLint* location',
+        'GLidProgram program, uint32_t name_bucket_id, '
+        'NonImmediate GLint* location',
     'result': ['GLint'],
     'error_return': -1, # http://www.opengl.org/sdk/docs/man/xhtml/glGetAttribLocation.xml
   },
@@ -1865,10 +1865,10 @@ _FUNCTION_INFO = {
     'result': ['SizedResult<GLint>'],
   },
   'GetUniformLocation': {
-    'type': 'HandWritten',
-    'needs_size': True,
+    'type': 'Custom',
     'cmd_args':
-        'GLidProgram program, const char* name, NonImmediate GLint* location',
+        'GLidProgram program, uint32_t name_bucket_id, '
+        'NonImmediate GLint* location',

[no sievers, 2014/07/10 20:47:46]

Can |NonImmediate| and the logic in this script that handles it go away now?

I think you'd have to add 'data_transfer_methods': ['shm']' here also for that
to still work then.

I tried to go back and see why it exists this way (added in r33095). Seems it
was originally used an an immediate commands, but was then switched to use the
bucket for the name (r42438, with r227757 removing the dead immediate code).

     'result': ['GLint'],
     'error_return': -1, # http://www.opengl.org/sdk/docs/man/xhtml/glGetUniformLocation.xml
   },