generate GetAttribLocation/GetUniformLocation by build_gles2_cmd_buffer.py

generate GetAttribLocation/GetUniformLocation by build_gles2_cmd_buffer.py

change to generate GetAttribLocation/GetUniformLocation functions by build_gles2_cmd_buffer.py 
and remove HandWritten code.

Bug=None
TEST=gpu_tests --gtest_filter="GLES2FormatTest.*"

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283494

[JungJik, 2014-06-16 12:55:06]

Please take a look :)

[JungJik, 2014-07-10 11:56:54]

On 2014/06/16 12:55:06, JungJik wrote:
> Please take a look :)

the patch is re-based.
before and after generating the functions,
actually the code is almost same.

excepting these code,

-COMPILE_ASSERT(sizeof(GetUniformLocation) == 20,
-               Sizeof_GetUniformLocation_is_not_24);

if Sizeof_GetUniformLocation_is_not_24 is an error caused by hand-written,
it should be Sizeof_GetUniformLocation_is_not_20.

PTAL again :)

[no sievers, 2014-07-10 20:47:46]

https://codereview.chromium.org/333303002/diff/40001/gpu/command_buffer/build...
File gpu/command_buffer/build_gles2_cmd_buffer.py (right):

https://codereview.chromium.org/333303002/diff/40001/gpu/command_buffer/build...
gpu/command_buffer/build_gles2_cmd_buffer.py:1871: 'NonImmediate GLint*
location',
Can |NonImmediate| and the logic in this script that handles it go away now?

I think you'd have to add 'data_transfer_methods': ['shm']' here also for that
to still work then.

I tried to go back and see why it exists this way (added in r33095). Seems it
was originally used an an immediate commands, but was then switched to use the
bucket for the name (r42438, with r227757 removing the dead immediate code).

[JungJik, 2014-07-13 08:29:25]

On 2014/07/10 20:47:46, sievers wrote:
>
https://codereview.chromium.org/333303002/diff/40001/gpu/command_buffer/build...
> File gpu/command_buffer/build_gles2_cmd_buffer.py (right):
> 
>
https://codereview.chromium.org/333303002/diff/40001/gpu/command_buffer/build...
> gpu/command_buffer/build_gles2_cmd_buffer.py:1871: 'NonImmediate GLint*
> location',
> Can |NonImmediate| and the logic in this script that handles it go away now?
done.
> 
> I think you'd have to add 'data_transfer_methods': ['shm']' here also for that
> to still work then.
done.
> 
> I tried to go back and see why it exists this way (added in r33095). Seems it
> was originally used an an immediate commands, but was then switched to use the
> bucket for the name (r42438, with r227757 removing the dead immediate code).

thanks for kind explanation.
it looks like that cmd-buffer is not updated for a while.
because some part of the document and comments doesn't correspond with the code.

[JungJik, 2014-07-15 12:35:44]

On 2014/07/13 08:29:25, JungJik wrote:
> On 2014/07/10 20:47:46, sievers wrote:
> >
>
https://codereview.chromium.org/333303002/diff/40001/gpu/command_buffer/build...
> > File gpu/command_buffer/build_gles2_cmd_buffer.py (right):
> > 
> >
>
https://codereview.chromium.org/333303002/diff/40001/gpu/command_buffer/build...
> > gpu/command_buffer/build_gles2_cmd_buffer.py:1871: 'NonImmediate GLint*
> > location',
> > Can |NonImmediate| and the logic in this script that handles it go away now?
> done.
> > 
> > I think you'd have to add 'data_transfer_methods': ['shm']' here also for
that
> > to still work then.
> done.
> > 
> > I tried to go back and see why it exists this way (added in r33095). Seems
it
> > was originally used an an immediate commands, but was then switched to use
the
> > bucket for the name (r42438, with r227757 removing the dead immediate code).
> 
> thanks for kind explanation.
> it looks like that cmd-buffer is not updated for a while.
> because some part of the document and comments doesn't correspond with the
code.

@sievers: could you take a look again?

[no sievers, 2014-07-15 19:36:07]

lgtm

[JungJik, 2014-07-16 02:29:42]

On 2014/07/15 19:36:07, sievers wrote:
> lgtm

thanks for lgtm :)

[JungJik, 2014-07-16 02:32:23]

The CQ bit was checked by jungjik.lee@samsung.com

[commit-bot: I haz the power, 2014-07-16 02:35:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jungjik.lee@samsung.com/333303002/60001

[commit-bot: I haz the power, 2014-07-16 20:46:14]

Change committed as 283494