Clean up webkit_param_traits.h to use SimilarTypeTraits for enums that don't...

chrome/common/webkit_param_traits.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file contains ParamTraits templates to support serialization of WebKit
 // data types over IPC.
 //
 // NOTE: IT IS IMPORTANT THAT ONLY POD (plain old data) TYPES ARE SERIALIZED.
 //
 // There are several reasons for this restrictions:
@@ skipping 44 matching lines @@
 
 template <>
 struct ParamTraits<WebKit::WebScreenInfo> {
   typedef WebKit::WebScreenInfo param_type;
   static void Write(Message* m, const param_type& p);
   static bool Read(const Message* m, void** iter, param_type* p);
   static void Log(const param_type& p, std::string* l);
 };
 
 template <>
-struct ParamTraits<WebKit::WebConsoleMessage::Level> {
-  typedef WebKit::WebConsoleMessage::Level param_type;
-  static void Write(Message* m, const param_type& p) {
-    WriteParam(m, static_cast<int>(p));
-  }
-  static bool Read(const Message* m, void** iter, param_type* r) {
-    int value;
-    if (!ReadParam(m, iter, &value))
-      return false;
-    *r = static_cast<param_type>(value);
-    return true;
-  }
-  static void Log(const param_type& p, std::string* l) {
-    LogParam(static_cast<int>(p), l);
-  }
+struct SimilarTypeTraits<WebKit::WebConsoleMessage::Level> {
+  typedef int Type;
 };
 
 template <>
-struct ParamTraits<WebKit::WebPopupType> {
-  typedef WebKit::WebPopupType param_type;
-  static void Write(Message* m, const param_type& p) {
-    WriteParam(m, static_cast<int>(p));
-  }
-  static bool Read(const Message* m, void** iter, param_type* r) {
-    int value;
-    if (!ReadParam(m, iter, &value))
-      return false;
-    *r = static_cast<param_type>(value);
-    return true;
-  }
-  static void Log(const param_type& p, std::string* l) {
-    LogParam(static_cast<int>(p), l);
-  }
+struct SimilarTypeTraits<WebKit::WebPopupType> {
+  typedef int Type;
 };
 
 template <>
 struct ParamTraits<WebKit::WebFindOptions> {
   typedef WebKit::WebFindOptions param_type;
   static void Write(Message* m, const param_type& p);
   static bool Read(const Message* m, void** iter, param_type* p);
   static void Log(const param_type& p, std::string* l);
 };
 
@@ skipping 115 matching lines @@
     LogParam(p.images, l);
     LogParam(p.cssStyleSheets, l);
     LogParam(p.scripts, l);
     LogParam(p.xslStyleSheets, l);
     LogParam(p.fonts, l);
     l->append("</WebCoreStats>");
   }
 };
 
 template <>
-struct ParamTraits<WebKit::WebTextDirection> {
-  typedef WebKit::WebTextDirection param_type;
-  static void Write(Message* m, const param_type& p) {
-    WriteParam(m, static_cast<int>(p));
-  }
-  static bool Read(const Message* m, void** iter, param_type* r) {
-    int value;
-    if (!ReadParam(m, iter, &value))
-      return false;
-    *r = static_cast<param_type>(value);
-    return true;
-  }
-  static void Log(const param_type& p, std::string* l) {
-    LogParam(static_cast<int>(p), l);
-  }
+struct SimilarTypeTraits<WebKit::WebTextDirection> {
+  typedef int Type;
 };
 
 template <>
-struct ParamTraits<WebKit::WebDragOperation> {
-  typedef WebKit::WebDragOperation param_type;
-  static void Write(Message* m, const param_type& p) {
-    m->WriteInt(p);
-  }
-  static bool Read(const Message* m, void** iter, param_type* r) {
-    int temp;
-    bool res = m->ReadInt(iter, &temp);
-    *r = static_cast<param_type>(temp);
-    return res;
-  }
-  static void Log(const param_type& p, std::string* l) {
-    l->append(StringPrintf("%d", p));
-  }
+struct SimilarTypeTraits<WebKit::WebDragOperation> {
+  typedef int Type;
 };
 
 template <>
 struct ParamTraits<WebKit::WebMediaPlayerAction> {
   typedef WebKit::WebMediaPlayerAction param_type;
   static void Write(Message* m, const param_type& p);
   static bool Read(const Message* m, void** iter, param_type* r);
   static void Log(const param_type& p, std::string* l);
 };
 
 template <>
-  struct ParamTraits<WebKit::WebContextMenuData::MediaType> {
-  typedef WebKit::WebContextMenuData::MediaType param_type;
-  static void Write(Message* m, const param_type& p) {
-    m->WriteInt(p);
-  }
-  static bool Read(const Message* m, void** iter, param_type* r) {
-    int temp;
-    bool res = m->ReadInt(iter, &temp);
-    *r = static_cast<param_type>(temp);
-    return res;
-  }
+struct SimilarTypeTraits<WebKit::WebContextMenuData::MediaType> {
+  typedef int Type;
 };
 
 template <>
 struct ParamTraits<WebKit::WebCompositionUnderline> {
   typedef WebKit::WebCompositionUnderline param_type;
   static void Write(Message* m, const param_type& p);
   static bool Read(const Message* m, void** iter, param_type* p);
   static void Log(const param_type& p, std::string* l);
 };
 
@@ skipping 32 matching lines @@
 };
 
 template <>
 struct SimilarTypeTraits<WebKit::WebFileSystem::Type> {
   typedef int Type;
 };
 
 }  // namespace IPC
 
 #endif  // CHROME_COMMON_WEBKIT_PARAM_TRAITS_H_