Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Issue 33323003: Fix the order of the event dispatch. (Closed)

Created:
7 years, 2 months ago by Hiro Komatsu
Modified:
7 years, 1 month ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix the order of the event dispatch. UpdateTextInputType should be called before SyncSelectionIfRequired. UpdateTextInputType may send TextInputTypeChanged to notify the focus was changed, and SyncSelectionIfRequired may send SelectionChanged to notify the selection was changed. Focus change should be notified before selection change. BUG=310562 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233449

Patch Set 1 #

Patch Set 2 : Add comment. #

Patch Set 3 : Add a test case. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -1 line) Patch
M content/renderer/render_view_browsertest.cc View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
Hiro Komatsu
7 years, 2 months ago (2013-10-23 10:47:51 UTC) #1
Seigo Nonaka
lgtm, please wait aurimas's response :)
7 years, 2 months ago (2013-10-23 11:20:24 UTC) #2
aurimas (slooooooooow)
On 2013/10/23 11:20:24, Seigo Nonaka wrote: > lgtm, please wait aurimas's response :) lgtm if ...
7 years, 2 months ago (2013-10-24 06:27:42 UTC) #3
Hiro Komatsu
Hi Jochen, Would you review this patch. I also received LGTMs from nona and aurimas ...
7 years, 2 months ago (2013-10-24 06:41:13 UTC) #4
jochen (gone - plz use gerrit)
can you add a test that failed without this patch?
7 years, 2 months ago (2013-10-24 12:35:47 UTC) #5
Hiro Komatsu
On 2013/10/24 12:35:47, jochen - OOO 1. - 3. 11 wrote: > can you add ...
7 years, 1 month ago (2013-11-01 12:58:52 UTC) #6
jochen (gone - plz use gerrit)
lgtm, thanks
7 years, 1 month ago (2013-11-04 09:09:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/komatsu@chromium.org/33323003/150001
7 years, 1 month ago (2013-11-04 11:51:15 UTC) #8
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=97174
7 years, 1 month ago (2013-11-04 14:51:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/komatsu@chromium.org/33323003/150001
7 years, 1 month ago (2013-11-05 01:35:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/komatsu@chromium.org/33323003/150001
7 years, 1 month ago (2013-11-05 03:01:19 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=219419
7 years, 1 month ago (2013-11-05 06:54:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/komatsu@chromium.org/33323003/150001
7 years, 1 month ago (2013-11-06 01:49:21 UTC) #13
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=220325
7 years, 1 month ago (2013-11-06 05:41:00 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/komatsu@chromium.org/33323003/150001
7 years, 1 month ago (2013-11-06 23:45:25 UTC) #15
commit-bot: I haz the power
7 years, 1 month ago (2013-11-07 01:00:49 UTC) #16
Message was sent while issue was closed.
Change committed as 233449

Powered by Google App Engine
This is Rietveld 408576698