Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 333223003: DevTools: fixed test ExtensionApiTest.Debugger (Closed)

Created:
6 years, 6 months ago by vkuzkokov
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

DevTools: fixed test ExtensionApiTest.Debugger BUG=380082, 234166 TBR=finnur Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277740

Patch Set 1 #

Patch Set 2 : Removed "MAYBE" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M chrome/browser/extensions/api/debugger/debugger_apitest.cc View 1 1 chunk +1 line, -9 lines 0 comments Download
M chrome/test/data/extensions/api_test/debugger/background.js View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
vkuzkokov
6 years, 6 months ago (2014-06-17 07:14:24 UTC) #1
Vladislav Kaznacheev
lgtm
6 years, 6 months ago (2014-06-17 10:07:37 UTC) #2
vkuzkokov
The CQ bit was checked by vkuzkokov@chromium.org
6 years, 6 months ago (2014-06-17 10:12:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vkuzkokov@chromium.org/333223003/20001
6 years, 6 months ago (2014-06-17 10:16:28 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-17 11:42:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/74179)
6 years, 6 months ago (2014-06-17 11:42:58 UTC) #6
vkuzkokov
The CQ bit was checked by vkuzkokov@chromium.org
6 years, 6 months ago (2014-06-17 12:12:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vkuzkokov@chromium.org/333223003/20001
6 years, 6 months ago (2014-06-17 12:13:11 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 12:19:48 UTC) #9
Message was sent while issue was closed. 
Change committed as 277740

Powered by Google App Engine
This is Rietveld 408576698