Source/modules/websockets/WorkerThreadableWebSocketChannel.h - Issue 333223002: ThreadableWebSocketChannelClientWrapper don't need suspend / resume code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/websockets/WorkerThreadableWebSocketChannel.h

Issue 333223002: ThreadableWebSocketChannelClientWrapper don't need suspend / resume code. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp ('k') | Source/modules/websockets/WorkerThreadableWebSocketChannel.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/websockets/WorkerThreadableWebSocketChannel.h

diff --git a/Source/modules/websockets/WorkerThreadableWebSocketChannel.h b/Source/modules/websockets/WorkerThreadableWebSocketChannel.h

index 7ff72e6cd9162ea4092fdf1ee330f38d26084a20..c1b538112a5ad1b9720658e208f7989c78b0489d 100644

--- a/Source/modules/websockets/WorkerThreadableWebSocketChannel.h

+++ b/Source/modules/websockets/WorkerThreadableWebSocketChannel.h

@@ -85,8 +85,8 @@ public:

virtual void close(int code, const String& reason) OVERRIDE;

virtual void fail(const String& reason, MessageLevel, const String&, unsigned) OVERRIDE;

virtual void disconnect() OVERRIDE; // Will suppress didClose().

- virtual void suspend() OVERRIDE;

- virtual void resume() OVERRIDE;

+ virtual void suspend() OVERRIDE { }

+ virtual void resume() OVERRIDE { }

virtual void trace(Visitor*) OVERRIDE;

@@ -111,8 +111,6 @@ public:

void close(int code, const String& reason);

void fail(const String& reason, MessageLevel, const String& sourceURL, unsigned lineNumber);

void disconnect();

- void suspend();

- void resume();

// WebSocketChannelClient functions.

virtual void didConnect(const String& subprotocol, const String& extensions) OVERRIDE;

@@ -153,8 +151,6 @@ private:

void close(int code, const String& reason);

void fail(const String& reason, MessageLevel, const String& sourceURL, unsigned lineNumber);

void disconnect();

- void suspend();

- void resume();

private:

Bridge(PassRefPtrWillBeRawPtr<ThreadableWebSocketChannelClientWrapper>, WorkerGlobalScope&);