Issue 333203003: Change GLInternalFormat param from GLint to GLenum.

Issue 333203003: Change GLInternalFormat param from GLint to GLenum. (Closed)

Created:
6 years, 6 months ago by JungJik

Modified:
6 years, 6 months ago

Reviewers:
piman

CC:
chromium-reviews, piman+watch_chromium.org, cc-bugs_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Change GLInternalFormat param from GLint to GLenum. Original GLInternalFormat type is GLenum (http://goo.gl/fXcvqh). But GLint is used in AsyncTexImage2DCHROMIUM params. This is a patch for changing the type from GLint to GLenum. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277715

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -13 lines)			Patch
M	cc/test/test_gles2_interface.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	cc/test/test_gles2_interface.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/client/gles2_c_lib_autogen.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/client/gles2_implementation.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/client/gles2_implementation_autogen.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/client/gles2_interface_autogen.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/client/gles2_interface_stub_autogen.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/client/gles2_trace_implementation_autogen.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/cmd_buffer_functions.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 7 (0 generated)

kloveless

On 2014/06/16 09:53:28, JungJik wrote: > PTAL :) I haven't worked on this code for ...

6 years, 6 months ago (2014-06-16 17:01:03 UTC) #2

JungJik

On 2014/06/16 19:20:45, piman wrote: > LGTM. Thanks for the review. :)

6 years, 6 months ago (2014-06-17 01:59:45 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jungjik.lee@samsung.com/333203003/20001

6 years, 6 months ago (2014-06-17 02:02:31 UTC) #6

Message was sent while issue was closed.

Change committed as 277715