Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Side by Side Diff: chrome/common/extensions/api/api.gyp

Issue 333173004: Fix GN review comments. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/common/extensions/api/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 # All files are stored in these lists which are referenced in the target 6 # All files are stored in these lists which are referenced in the target
7 # below so that the GN build of this target can read in this dictionary and 7 # below so that the GN build of this target can read in this dictionary and
8 # duplicate the same logic without the lists getting out-of-sync. The GN 8 # duplicate the same logic without the lists getting out-of-sync. The GN
9 # .gypi reader can not process conditions and does not know about targets, 9 # .gypi reader can not process conditions and does not know about targets,
10 # etc., it just reads Python dictionaries. 10 # etc., it just reads Python dictionaries.
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
213 ['branding=="Chrome" and chromeos==1', { 213 ['branding=="Chrome" and chromeos==1', {
214 'schema_files': [ 214 'schema_files': [
215 '<@(chromeos_branded_schema_files)', 215 '<@(chromeos_branded_schema_files)',
216 ], 216 ],
217 }], 217 }],
218 ], 218 ],
219 'cc_dir': 'chrome/common/extensions/api', 219 'cc_dir': 'chrome/common/extensions/api',
220 'root_namespace': 'extensions::api', 220 'root_namespace': 'extensions::api',
221 }, 221 },
222 'dependencies': [ 222 'dependencies': [
223 # Different APIs include some headers crom chrome/common that in turn 223 # Different APIs include some headers from chrome/common that in turn
224 # include generated headers from these targets. 224 # include generated headers from these targets.
225 # TODO(brettw) this should be made unnecessary if possible. 225 # TODO(brettw) this should be made unnecessary if possible.
226 '<(DEPTH)/components/components.gyp:component_metrics_proto', 226 '<(DEPTH)/components/components.gyp:component_metrics_proto',
227 '<(DEPTH)/device/serial/serial.gyp:device_serial', 227 '<(DEPTH)/device/serial/serial.gyp:device_serial',
228 228
229 '<(DEPTH)/content/content.gyp:content_browser', 229 '<(DEPTH)/content/content.gyp:content_browser',
230 '<(DEPTH)/skia/skia.gyp:skia', 230 '<(DEPTH)/skia/skia.gyp:skia',
231 '<(DEPTH)/sync/sync.gyp:sync', 231 '<(DEPTH)/sync/sync.gyp:sync',
232 ], 232 ],
233 'conditions': [ 233 'conditions': [
234 ['chromeos==1', { 234 ['chromeos==1', {
235 'dependencies': [ 235 'dependencies': [
236 '<(DEPTH)/chrome/chrome.gyp:drive_proto', 236 '<(DEPTH)/chrome/chrome.gyp:drive_proto',
237 ], 237 ],
238 }], 238 }],
239 ], 239 ],
240 }, 240 },
241 ], 241 ],
242 } 242 }
OLDNEW
« no previous file with comments | « chrome/common/extensions/api/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698