Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: chrome/common/extensions/api/BUILD.gn

Issue 333173004: Fix GN review comments. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/common/extensions/api/api.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/features.gni") 5 import("//build/config/features.gni")
6 import("//build/json_schema.gni") 6 import("//build/json_schema.gni")
7 7
8 gypi_values = exec_script( 8 gypi_values = exec_script(
9 "//build/gypi_to_gn.py", 9 "//build/gypi_to_gn.py",
10 [ rebase_path("api.gyp") ], 10 [ rebase_path("api.gyp") ],
(...skipping 21 matching lines...) Expand all
32 if (is_chrome_branded) { 32 if (is_chrome_branded) {
33 schema_sources += gypi_values.chromeos_branded_schema_files 33 schema_sources += gypi_values.chromeos_branded_schema_files
34 } 34 }
35 } 35 }
36 if (enable_webrtc) { 36 if (enable_webrtc) {
37 schema_sources += gypi_values.webrtc_schema_files 37 schema_sources += gypi_values.webrtc_schema_files
38 } 38 }
39 } 39 }
40 40
41 schema_deps = [ 41 schema_deps = [
42 # Different APIs include some headers crom chrome/common that in turn 42 # Different APIs include some headers from chrome/common that in turn
43 # include generated headers from these targets. 43 # include generated headers from these targets.
44 # TODO(brettw) this should be made unnecessary if possible. 44 # TODO(brettw) this should be made unnecessary if possible.
45 "//components/metrics/proto", 45 "//components/metrics/proto",
46 "//device/serial", 46 "//device/serial",
47 47
48 "//content/public/browser", 48 "//content/public/browser",
49 "//skia", 49 "//skia",
50 "//sync", 50 "//sync",
51 ] 51 ]
52 if (is_chromeos) { 52 if (is_chromeos) {
53 # deps += [ "<(DEPTH)/chrome/chrome.gyp:drive_proto" ] TODO)GYP) 53 # deps += [ "<(DEPTH)/chrome/chrome.gyp:drive_proto" ] TODO)GYP)
54 } 54 }
55 55
56 json_schema_bundle("api_bundle") { 56 json_schema_bundle("api_bundle") {
57 visibility = ":api" 57 visibility = ":api"
58 sources = schema_sources 58 sources = schema_sources
59 if (!is_android) { 59 if (!is_android) {
60 sources += gypi_values.main_non_compiled_schema_files 60 sources += gypi_values.main_non_compiled_schema_files
61 } 61 }
62 62
63 root_namespace = "extensions::api" 63 root_namespace = "extensions::api"
64 deps = schema_deps + [ ":api_compile" ] 64 deps = schema_deps + [ ":api_compile" ]
65
66 } 65 }
67 66
68 json_schema_compile("api_compile") { 67 json_schema_compile("api_compile") {
69 visibility = ":*" 68 visibility = ":*"
70 sources = schema_sources 69 sources = schema_sources
71 root_namespace = "extensions::api" 70 root_namespace = "extensions::api"
72 deps = schema_deps 71 deps = schema_deps
73 } 72 }
OLDNEW
« no previous file with comments | « no previous file | chrome/common/extensions/api/api.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698