mojo/examples/window_manager/window_manager.cc - Issue 333173003: Mojo: Fix DCHECK on middle-click in window manager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/examples/window_manager/window_manager.cc

Issue 333173003: Mojo: Fix DCHECK on middle-click in window manager. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/examples/window_manager/window_manager.cc

diff --git a/mojo/examples/window_manager/window_manager.cc b/mojo/examples/window_manager/window_manager.cc

index 78a2be794a3d9577c2404f4ee0dda176deabdb8e..71e910b08ffb6c75682c48512b06a455eea13049 100644

--- a/mojo/examples/window_manager/window_manager.cc

+++ b/mojo/examples/window_manager/window_manager.cc

@@ -116,7 +116,8 @@ class WindowManager : public Application,

app_url = "mojo://mojo_embedded_app";

else if (event->flags & ui::EF_RIGHT_MOUSE_BUTTON)

app_url = "mojo://mojo_nesting_app";

- DCHECK(!app_url.empty());

+ if (app_url.empty())

+ return;

Node* node = view_manager_->GetNodeById(parent_node_id_);

navigation::NavigationDetailsPtr nav_details(

« no previous file with comments | « no previous file | no next file » | no next file with comments »