Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Unified Diff: Source/core/css/resolver/FilterOperationResolver.cpp

Issue 333163004: Remove explicit bounds check from CSSValueList::item (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: address comment Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/resolver/CSSToStyleMap.cpp ('k') | Source/core/css/resolver/FontBuilder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/resolver/FilterOperationResolver.cpp
diff --git a/Source/core/css/resolver/FilterOperationResolver.cpp b/Source/core/css/resolver/FilterOperationResolver.cpp
index fdb2e957ab40a50b9f7ca63ca11ea243c93aa4bc..7d808a6d9766983157434fe3b4a2444cb742db26 100644
--- a/Source/core/css/resolver/FilterOperationResolver.cpp
+++ b/Source/core/css/resolver/FilterOperationResolver.cpp
@@ -104,7 +104,7 @@ bool FilterOperationResolver::createFilterOperations(CSSValue* inValue, const CS
if (operationType == FilterOperation::REFERENCE) {
if (filterValue->length() != 1)
continue;
- CSSValue* argument = filterValue->itemWithoutBoundsCheck(0);
+ CSSValue* argument = filterValue->item(0);
if (!argument->isSVGDocumentValue())
continue;
@@ -128,7 +128,7 @@ bool FilterOperationResolver::createFilterOperations(CSSValue* inValue, const CS
if (operationType != FilterOperation::DROP_SHADOW) {
bool haveNonPrimitiveValue = false;
for (unsigned j = 0; j < filterValue->length(); ++j) {
- if (!filterValue->itemWithoutBoundsCheck(j)->isPrimitiveValue()) {
+ if (!filterValue->item(j)->isPrimitiveValue()) {
haveNonPrimitiveValue = true;
break;
}
@@ -137,7 +137,7 @@ bool FilterOperationResolver::createFilterOperations(CSSValue* inValue, const CS
continue;
}
- CSSPrimitiveValue* firstValue = filterValue->length() && filterValue->itemWithoutBoundsCheck(0)->isPrimitiveValue() ? toCSSPrimitiveValue(filterValue->itemWithoutBoundsCheck(0)) : 0;
+ CSSPrimitiveValue* firstValue = filterValue->length() && filterValue->item(0)->isPrimitiveValue() ? toCSSPrimitiveValue(filterValue->item(0)) : 0;
switch (filterValue->operationType()) {
case CSSFilterValue::GrayscaleFilterOperation:
case CSSFilterValue::SepiaFilterOperation:
@@ -185,7 +185,7 @@ bool FilterOperationResolver::createFilterOperations(CSSValue* inValue, const CS
if (filterValue->length() != 1)
return false;
- CSSValue* cssValue = filterValue->itemWithoutBoundsCheck(0);
+ CSSValue* cssValue = filterValue->item(0);
if (!cssValue->isShadowValue())
continue;
« no previous file with comments | « Source/core/css/resolver/CSSToStyleMap.cpp ('k') | Source/core/css/resolver/FontBuilder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698