Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl

Issue 333163004: Remove explicit bounds check from CSSValueList::item (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: address comment Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/css/CSSValueList.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl
diff --git a/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl b/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl
index 339c7ca6a2a8f8960fbf3d26761b8b343c676d23..5672e52a1fb427b10f968bed4e57ea09fbb7b019 100644
--- a/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl
+++ b/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl
@@ -359,7 +359,7 @@ static bool lengthTypeAndValueMatch(const BorderImageLengthBox& borderImageLengt
int length = list ? list->length() : 0;
for (int i = 0; i < length; ++i) {
- CSSValue* currValue = list->itemWithoutBoundsCheck(i);
+ CSSValue* currValue = list->item(i);
if (!currValue->isPrimitiveValue())
continue;
@@ -431,7 +431,7 @@ static bool lengthTypeAndValueMatch(const BorderImageLengthBox& borderImageLengt
currChild = new FillLayer({{fill_layer_type}});
prevChild->setNext(currChild);
}
- state.styleMap().{{map_fill}}({{property_id}}, currChild, valueList->itemWithoutBoundsCheck(i));
+ state.styleMap().{{map_fill}}({{property_id}}, currChild, valueList->item(i));
prevChild = currChild;
currChild = currChild->next();
}
@@ -532,7 +532,7 @@ static bool lengthTypeAndValueMatch(const BorderImageLengthBox& borderImageLengt
CSSBoxType cssBox = BoxMissing;
CSSValueList* valueList = toCSSValueList(value);
for (unsigned i = 0; i < valueList->length(); ++i) {
- CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(valueList->itemWithoutBoundsCheck(i));
+ CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(valueList->item(i));
if (primitiveValue->isShape())
shape = basicShapeForValue(state, primitiveValue->getShapeValue());
else if (primitiveValue->getValueID() == CSSValueContentBox
« no previous file with comments | « no previous file | Source/core/css/CSSValueList.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698