Source/core/css/resolver/StyleBuilderCustom.cpp - Issue 333163004: Remove explicit bounds check from CSSValueList::item

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/StyleBuilderCustom.cpp

Issue 333163004: Remove explicit bounds check from CSSValueList::item (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/css/StylePropertySerializer.cpp ('K') | « Source/core/css/resolver/StyleBuilderConverter.cpp ('k') | Source/core/css/resolver/TransformBuilder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/resolver/StyleBuilderCustom.cpp

diff --git a/Source/core/css/resolver/StyleBuilderCustom.cpp b/Source/core/css/resolver/StyleBuilderCustom.cpp

index c9e9af60fb0ef27727a9db1c944eb2c7f89edc94..d0acdebaba93e36293f18213be6efd4408d3b6d0 100644

--- a/Source/core/css/resolver/StyleBuilderCustom.cpp

+++ b/Source/core/css/resolver/StyleBuilderCustom.cpp

@@ -223,7 +223,7 @@ void StyleBuilderFunctions::applyValueCSSPropertyCursor(StyleResolverState& stat

int len = list->length();

state.style()->setCursor(CURSOR_AUTO);

for (int i = 0; i < len; i++) {

- CSSValue* item = list->itemWithoutBoundsCheck(i);

+ CSSValue* item = list->item(i);

if (item->isCursorImageValue()) {

CSSCursorImageValue* image = toCSSCursorImageValue(item);

if (image->updateIfSVGCursorIsUsed(state.element())) // Elements with SVG cursors are not allowed to share style.

@@ -1030,7 +1030,7 @@ void StyleBuilderFunctions::applyValueCSSPropertyWebkitTextEmphasisStyle(StyleRe

if (list->length() != 2)

return;

for (unsigned i = 0; i < 2; ++i) {

- CSSValue* item = list->itemWithoutBoundsCheck(i);

+ CSSValue* item = list->item(i);

if (!item->isPrimitiveValue())

continue;