Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 333153003: DevTools: Revert stepping over/out on a call frame backend code. (Closed)

Created:
6 years, 6 months ago by aandrey
Modified:
6 years, 6 months ago
Reviewers:
pfeldman
CC:
blink-reviews, vsevik+blink_chromium.org, caseq+blink_chromium.org, arv+blink, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, loislo+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Revert stepping over/out on a call frame backend code. This code is unused. R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176464

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -92 lines) Patch
M Source/bindings/v8/DebuggerScript.js View 2 chunks +3 lines, -6 lines 0 comments Download
M Source/bindings/v8/ScriptDebugServer.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/bindings/v8/ScriptDebugServer.cpp View 1 chunk +10 lines, -18 lines 0 comments Download
M Source/core/inspector/InjectedScript.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InjectedScript.cpp View 1 chunk +0 lines, -15 lines 0 comments Download
M Source/core/inspector/InjectedScriptSource.js View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.h View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 2 chunks +4 lines, -26 lines 0 comments Download
M Source/core/inspector/JavaScriptCallFrame.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/JavaScriptCallFrame.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/inspector/PageDebuggerAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/protocol.json View 2 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
aandrey
6 years, 6 months ago (2014-06-18 14:51:41 UTC) #1
pfeldman
lgtm
6 years, 6 months ago (2014-06-18 18:26:26 UTC) #2
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 6 months ago (2014-06-18 22:19:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/333153003/1
6 years, 6 months ago (2014-06-18 22:20:13 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 23:54:25 UTC) #5
Message was sent while issue was closed.
Change committed as 176464

Powered by Google App Engine
This is Rietveld 408576698