Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Unified Diff: runtime/lib/errors_patch.dart

Issue 33313003: Report use of malbounded interface in type test. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/lib/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/errors_patch.dart
===================================================================
--- runtime/lib/errors_patch.dart (revision 28940)
+++ runtime/lib/errors_patch.dart (working copy)
@@ -32,23 +32,23 @@
patch class TypeError extends AssertionError {
TypeError._create(String url, int line, int column,
this._srcType, this._dstType, this._dstName,
- this._malformedError)
+ this._boundError)
: super._create("is assignable", url, line, column);
static _throwNew(int location,
Object src_value,
String dst_type_name,
String dst_name,
- String malformed_error)
+ String bound_error)
native "TypeError_throwNew";
String toString() {
- String str = (_malformedError != null) ? _malformedError : "";
+ String str = (_boundError != null) ? _boundError : "";
if ((_dstName != null) && (_dstName.length > 0)) {
str = "${str}type '$_srcType' is not a subtype of "
"type '$_dstType' of '$_dstName'.";
} else {
- str = "${str}malformed type used.";
+ str = "${str}malbounded type used.";
}
return str;
}
@@ -56,19 +56,19 @@
final String _srcType;
final String _dstType;
final String _dstName;
- final String _malformedError;
+ final String _boundError;
}
patch class CastError extends Error {
CastError._create(this._url, this._line, this._column,
this._srcType, this._dstType, this._dstName,
- this._malformedError);
+ this._boundError);
// A CastError is allocated by TypeError._throwNew() when dst_name equals
// Exceptions::kCastErrorDstName.
String toString() {
- String str = (_malformedError != null) ? _malformedError : "";
+ String str = (_boundError != null) ? _boundError : "";
str = "${str}type '$_srcType' is not a subtype of "
"type '$_dstType' in type cast.";
return str;
@@ -81,7 +81,7 @@
final String _srcType;
final String _dstType;
final String _dstName;
- final String _malformedError;
+ final String _boundError;
}
patch class FallThroughError {
« no previous file with comments | « no previous file | runtime/lib/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698