components/data_reduction_proxy/common/data_reduction_proxy_headers.cc - Issue 333113002: Move data reduction proxy to Chrome-Proxy header for authentication

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/common/data_reduction_proxy_headers.cc

Issue 333113002: Move data reduction proxy to Chrome-Proxy header for authentication (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@flywheel-refactor-net-fake-a-redirect-response-headers-chrome-proxy-auth

Patch Set: errata Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/browser/http_auth_handler_data_reduction_proxy_unittest.cc ('k') | components/data_reduction_proxy/common/data_reduction_proxy_headers_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/common/data_reduction_proxy_headers.cc

diff --git a/components/data_reduction_proxy/common/data_reduction_proxy_headers.cc b/components/data_reduction_proxy/common/data_reduction_proxy_headers.cc

index b7ad3083964dd15951a03ece16a50e123a4af048..773d14c7042f1443b5c757196c84bec974f702cd 100644

--- a/components/data_reduction_proxy/common/data_reduction_proxy_headers.cc

+++ b/components/data_reduction_proxy/common/data_reduction_proxy_headers.cc

@@ -121,12 +121,6 @@ GetDataReductionProxyBypassEventType(

// Fall back if a 500, 502 or 503 is returned.

return ProxyService::INTERNAL_SERVER_ERROR_BYPASS;

}

- // TODO(kundaji): Bypass if Proxy-Authenticate header value cannot be

- // interpreted by data reduction proxy.

- if (headers->response_code() == net::HTTP_PROXY_AUTHENTICATION_REQUIRED &&

- !headers->HasHeader("Proxy-Authenticate")) {

- return ProxyService::MALFORMED_407_BYPASS;

- }

if (!HasDataReductionProxyViaHeader(headers) &&

(headers->response_code() != net::HTTP_NOT_MODIFIED)) {

// A Via header might not be present in a 304. Since the goal of a 304