chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc - Issue 333113002: Move data reduction proxy to Chrome-Proxy header for authentication

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc

Issue 333113002: Move data reduction proxy to Chrome-Proxy header for authentication (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@flywheel-refactor-net-fake-a-redirect-response-headers-chrome-proxy-auth

Patch Set: Callback returns void Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/net/chrome_network_delegate.cc ('K') | « chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.cc ('k') | chrome/browser/profiles/profile_impl_io_data.cc » ('j') | net/base/network_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc

diff --git a/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc b/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc

index 84ff76d66afcc2168da17bf73c470e53d6b86521..1903e0f030da847ef0ea363a15218a14d3b8b8e7 100644

--- a/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc

+++ b/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc

@@ -22,7 +22,6 @@ using testing::_;

using testing::AnyNumber;

using testing::Return;

-const char kDataReductionProxyOrigin[] = "https://foo.com:443/";

const char kDataReductionProxyDev[] = "http://foo-dev.com:80";

template <class C>

@@ -101,7 +100,6 @@ class DataReductionProxySettingsAndroidTest

virtual void SetUp() OVERRIDE {

env_ = base::android::AttachCurrentThread();

DataReductionProxySettingsAndroid::Register(env_);

- DataReductionProxySettingsTestBase::AddProxyToCommandLine();

DataReductionProxySettingsTestBase::SetUp();

}

@@ -118,7 +116,7 @@ TEST_F(DataReductionProxySettingsAndroidTest, TestGetDataReductionProxyOrigin) {

Settings()->GetDataReductionProxyOrigin(env_, NULL);

ASSERT_TRUE(result.obj());

const base::android::JavaRef<jstring>& str_ref = result;

- EXPECT_EQ(GURL(kDataReductionProxyOrigin),

+ EXPECT_EQ(GURL(expected_params_->DefaultOrigin()),

GURL(ConvertJavaStringToUTF8(str_ref)));

}