Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1100)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java

Issue 333113002: Move data reduction proxy to Chrome-Proxy header for authentication (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@flywheel-refactor-net-fake-a-redirect-response-headers-chrome-proxy-auth
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java b/chrome/android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java
index 4444a6f3310f06b179896bed10151403627204ae..57904a6b8ad7e2581e6c1e4eaaa55dd9ee3157a4 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java
@@ -137,30 +137,6 @@ public class DataReductionProxySettings {
}
/**
- * Returns true if the host and realm (as passed in to Tab.onReceivedHttpAuthRequest()) are such
- * that a authentication token can be generated. The host must match one of the configured proxy
- * hosts, and the realm must be prefixed with the authentication realm string used by the data
- * reduction proxies.
- * @param host The host requesting authentication.
- * @param realm The authentication realm.
- * @return True if host and realm can be authenticated.
- */
- public boolean isAcceptableAuthChallenge(String host, String realm) {
nyquist 2014/06/24 18:11:21 Wouldn't this break the downstream build? Is there
bengr 2014/06/24 18:24:11 I sent you a downstream CL to review. I intend to
- return nativeIsAcceptableAuthChallenge(mNativeDataReductionProxySettings, host, realm);
- }
-
- /**
- * Returns an authentication token for the data reduction proxy. If the token cannot be
- * generated, an empty string is returned.
- * @param host The host requesting authentication.
- * @param realm The authentication realm.
- * @return The generated token.
- */
- public String getTokenForAuthChallenge(String host, String realm) {
- return nativeGetTokenForAuthChallenge(mNativeDataReductionProxySettings, host, realm);
- }
-
- /**
* Retrieves the history of daily totals of bytes that would have been
* received if no data reducing mechanism had been applied.
* @return The history of daily totals
@@ -213,10 +189,6 @@ public class DataReductionProxySettings {
long nativeDataReductionProxySettingsAndroid);
private native ContentLengths nativeGetContentLengths(
long nativeDataReductionProxySettingsAndroid);
- private native boolean nativeIsAcceptableAuthChallenge(
- long nativeDataReductionProxySettingsAndroid, String host, String realm);
- private native String nativeGetTokenForAuthChallenge(
- long nativeDataReductionProxySettingsAndroid, String host, String realm);
private native long[] nativeGetDailyOriginalContentLengths(
long nativeDataReductionProxySettingsAndroid);
private native long[] nativeGetDailyReceivedContentLengths(

Powered by Google App Engine
This is Rietveld 408576698