Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 333063003: Deflake svg/custom/textPath-change-reference2.svg (Closed)

Created:
6 years, 6 months ago by pdr.
Modified:
6 years, 6 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Deflake svg/custom/textPath-change-reference2.svg This is a speculative fix for the flakiness we are seeing on the textPath-change-reference2.svg test[1]. The failure is not reproducable locally but appears as if runTest() is never called. This patch refactors the test to not depend on runTest(). In addition, the test ids have been refactored to be understandable. [1] http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&showAllRuns=true&showExpectations=true&tests=svg%2Fcustom%2FtextPath-change-reference2.svg BUG=384566 TBR=dpranke Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176137

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M LayoutTests/svg/custom/textPath-change-reference2.svg View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
pdr.
6 years, 6 months ago (2014-06-13 21:37:15 UTC) #1
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 6 months ago (2014-06-13 21:42:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/333063003/1
6 years, 6 months ago (2014-06-13 21:43:19 UTC) #3
Dirk Pranke
seems plausible, though it would be interesting to know why the onLoad() wasn't firing or ...
6 years, 6 months ago (2014-06-13 21:43:30 UTC) #4
pdr.
On 2014/06/13 21:43:30, Dirk Pranke wrote: > seems plausible, though it would be interesting to ...
6 years, 6 months ago (2014-06-13 21:44:01 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-13 22:46:28 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 23:39:32 UTC) #7
Message was sent while issue was closed.
Change committed as 176137

Powered by Google App Engine
This is Rietveld 408576698