Untangle RNG from v8 core

src/utils/random-number-generator.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/utils/random-number-generator.h"
 
 #include <stdio.h>
 #include <stdlib.h>
 
-#include "src/flags.h"
+#include <new>
+
+#include "src/base/macros.h"
 #include "src/platform/mutex.h"
 #include "src/platform/time.h"
-#include "src/utils.h"
 
 namespace v8 {
 namespace internal {
 
 static LazyMutex entropy_mutex = LAZY_MUTEX_INITIALIZER;
 static RandomNumberGenerator::EntropySource entropy_source = NULL;
 
 
 // static
 void RandomNumberGenerator::SetEntropySource(EntropySource source) {
   LockGuard<Mutex> lock_guard(entropy_mutex.Pointer());
   entropy_source = source;
 }
 
 
 RandomNumberGenerator::RandomNumberGenerator() {
-  // Check --random-seed flag first.
-  if (FLAG_random_seed != 0) {
-    SetSeed(FLAG_random_seed);
-    return;
-  }
-
   // Check if embedder supplied an entropy source.
   { LockGuard<Mutex> lock_guard(entropy_mutex.Pointer());
     if (entropy_source != NULL) {
       int64_t seed;
       if (entropy_source(reinterpret_cast<unsigned char*>(&seed),
                          sizeof(seed))) {
         SetSeed(seed);
         return;
       }
     }
@@ skipping 34 matching lines @@
   seed ^= TimeTicks::Now().ToInternalValue() << 8;
   SetSeed(seed);
 #endif  // V8_OS_CYGWIN || V8_OS_WIN
 }
 
 
 int RandomNumberGenerator::NextInt(int max) {
   ASSERT_LE(0, max);
 
   // Fast path if max is a power of 2.
-  if (IsPowerOf2(max)) {
+  if (IS_POWER_OF_TWO(max)) {
     return static_cast<int>((max * static_cast<int64_t>(Next(31))) >> 31);
   }
 
   while (true) {
     int rnd = Next(31);
     int val = rnd % max;
     if (rnd - val + (max - 1) >= 0) {
       return val;
     }
   }
@@ skipping 26 matching lines @@
   seed_ = seed;
   return static_cast<int>(seed >> (48 - bits));
 }
 
 
 void RandomNumberGenerator::SetSeed(int64_t seed) {
   seed_ = (seed ^ kMultiplier) & kMask;
 }
 
 } }  // namespace v8::internal