Issue 33303007: Xoom rebaselines.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 33303007: Xoom rebaselines. (Closed)

Created:
7 years, 2 months ago by Stephen White

Modified:
7 years, 2 months ago

Reviewers:
epoger

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Xoom rebaselines. Note: Some of these had no base versions in GS corresponding to the hashes in the JSON, causing the svndiff script to barf. I hacked it up to let me finish, but it should probably handle the case of a missing hash more gracefully. TBR=epoger Committed: https://code.google.com/p/skia/source/detail?r=11900

Patch Set 1 #

Patch Set 2 : Revert hacks to svndiff.py #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -78 lines)			Patch
	M	expectations/gm/Test-Android-Xoom-Tegra2-Arm7-Debug/expected-results.json	View		39 chunks	+39 lines, -39 lines	0 comments	Download
	M	expectations/gm/Test-Android-Xoom-Tegra2-Arm7-Release/expected-results.json	View		39 chunks	+39 lines, -39 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Stephen White

Committed patchset #2 manually as r11900 (presubmit successful).

7 years, 2 months ago (2013-10-21 22:00:52 UTC) #1

epoger

7 years, 2 months ago (2013-10-23 14:49:28 UTC) #2

Message was sent while issue was closed.

LGTM

Thanks for letting me know about the problem.  Brian reported something similar
a few days ago: 

https://code.google.com/p/skia/issues/detail?id=1731 ('Unable to svndiff Xoom
images')

I have updated that bug with a reference to this CL.

For now, I don't want to hide this problem.  It "should never happen".  But you
know how that goes.

Expand Messages | Collapse Messages