Issue 33303004: android buildbot: Don't cd into src/ by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 33303004: android buildbot: Don't cd into src/ by default. (Closed)

Created:
7 years, 2 months ago by Nico

Modified:
7 years, 2 months ago

Reviewers:
Isaac (away)

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

android buildbot: Don't cd into src/ by default. Explicitly pass cwd=CHROME_SRC_DIR for the commands that look like they need it. Continuation of https://codereview.chromium.org/32323005/ BUG=294387

Patch Set 1 #

Patch Set 2 : RIEEEEETVEEEEELD #

Patch Set 3 : more #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -14 lines)			Patch
build/android/buildbot/bb_device_steps.py	View	1 2	10 chunks	+16 lines, -12 lines	0 comments	Download
build/android/buildbot/bb_run_bot.py	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
build/android/buildbot/bb_utils.py	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

7 years, 2 months ago (2013-10-22 00:38:35 UTC) #3

No, https://codereview.chromium.org/32323005/ is now enough. Closing this.

Expand Messages | Collapse Messages