src/macro-assembler.h - Issue 333013002: Check alpha-sorting of includes during presubmit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/macro-assembler.h

Issue 333013002: Check alpha-sorting of includes during presubmit. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/macro-assembler.h

diff --git a/src/macro-assembler.h b/src/macro-assembler.h

index a11afd863bb09910ae6008a203912e058b014315..70952e2a7b9a0ae51067bd5dfd5208ba45f5c49f 100644

--- a/src/macro-assembler.h

+++ b/src/macro-assembler.h

@@ -41,7 +41,7 @@ const int kInvalidProtoDepth = -1;

#include "src/assembler.h"

#include "src/ia32/assembler-ia32.h"

#include "src/ia32/assembler-ia32-inl.h"

-#include "src/code.h" // must be after assembler_*.h

+#include "src/code.h" // NOLINT, must be after assembler_*.h

#include "src/ia32/macro-assembler-ia32.h"

#elif V8_TARGET_ARCH_X64

#include "src/assembler.h"

@@ -52,7 +52,7 @@ const int kInvalidProtoDepth = -1;

#elif V8_TARGET_ARCH_ARM64

#include "src/arm64/constants-arm64.h"

#include "src/assembler.h"

-#include "src/arm64/assembler-arm64.h"

+#include "src/arm64/assembler-arm64.h" // NOLINT

#include "src/arm64/assembler-arm64-inl.h"

#include "src/code.h" // must be after assembler_*.h

#include "src/arm64/macro-assembler-arm64.h"

@@ -60,14 +60,14 @@ const int kInvalidProtoDepth = -1;

#elif V8_TARGET_ARCH_ARM

#include "src/arm/constants-arm.h"

#include "src/assembler.h"

-#include "src/arm/assembler-arm.h"

+#include "src/arm/assembler-arm.h" // NOLINT

#include "src/arm/assembler-arm-inl.h"

#include "src/code.h" // must be after assembler_*.h

#include "src/arm/macro-assembler-arm.h"

#elif V8_TARGET_ARCH_MIPS

#include "src/mips/constants-mips.h"

#include "src/assembler.h"

-#include "src/mips/assembler-mips.h"

+#include "src/mips/assembler-mips.h" // NOLINT

#include "src/mips/assembler-mips-inl.h"

#include "src/code.h" // must be after assembler_*.h

#include "src/mips/macro-assembler-mips.h"

« no previous file with comments | « src/lithium-codegen.cc ('k') | src/mips/disasm-mips.cc » ('j') | no next file with comments »