Issue 333011: Fix premultiplication mismatch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 333011: Fix premultiplication mismatch (Closed)

Created:
11 years, 2 months ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
tony, Matt Perry

CC:
chromium-reviews_googlegroups.com, rafaelw

Visibility:
Public.

Description

Fix premultiplication mismatch in chrome.browserAction.setIcon(). SkBitmap expects premultiplied values, canvas returns them not premultiplied. BUG=24643 TEST=install gmail browser action sample. Should not have weird colorful artifacts around edges. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29996

Patch Set 1 #

Total comments: 1

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -6 lines)			Patch
	M	chrome/renderer/extensions/extension_process_bindings.cc	View		1 chunk	+9 lines, -6 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tony

http://codereview.chromium.org/333011/diff/1/2 File chrome/renderer/extensions/extension_process_bindings.cc (right): http://codereview.chromium.org/333011/diff/1/2#newcode437 Line 437: // |data| is RGBA not premutiplied, pixels is ...

11 years, 2 months ago (2009-10-23 16:52:17 UTC) #2

Aaron Boodman

11 years, 2 months ago (2009-10-23 18:03:56 UTC) #4

On 2009/10/23 16:52:17, tony wrote:
> http://codereview.chromium.org/333011/diff/1/2
> File chrome/renderer/extensions/extension_process_bindings.cc (right):
> 
> http://codereview.chromium.org/333011/diff/1/2#newcode437
> Line 437: // |data| is RGBA not premutiplied, pixels is ARGB premultiplied.
> Drive-by-nit: third_party/skia/include/core/SkColor.h has SkPreMultiply*
> methods.  SkUnPreMultiply.h has the reverse.

Oh boo. I had so much fun doing it by hand.

Ok.

Expand Messages | Collapse Messages