aw: Support the platform specific key-systems.

aw: Support the platform specific key-systems.

BUG=322395
Change-Id: Ie0376052892349f18db5d60737f6329b8c92eb1c

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278207

[ycheo (away), 2014-06-13 13:25:58]

PTAL.

@xhwang, qinmin for media/base/android*

@mkosiba, benm for android_webview/*

[ycheo (away), 2014-06-13 13:27:37]

Android framework CLs related to this CL are as follows:
https://googleplex-android-review.git.corp.google.com/#/c/484493/
https://googleplex-android-review.git.corp.google.com/#/c/484437/
https://googleplex-android-review.git.corp.google.com/#/c/484494/

[mkosiba (inactive), 2014-06-16 08:38:21]

android_webview/ LGTM

https://codereview.chromium.org/333003003/diff/1/android_webview/java/src/org...
File android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java
(right):

https://codereview.chromium.org/333003003/diff/1/android_webview/java/src/org...
android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java:56:
initializePlatformKeySystem();
any idea how much time this will add to our startup?

[ycheo (away), 2014-06-16 11:05:53]

https://codereview.chromium.org/333003003/diff/1/android_webview/java/src/org...
File android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java
(right):

https://codereview.chromium.org/333003003/diff/1/android_webview/java/src/org...
android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java:56:
initializePlatformKeySystem();
On 2014/06/16 08:38:20, mkosiba wrote:
> any idea how much time this will add to our startup?
Did a quick experiment using android.os.SystemClock:
- Target device/build: New N7, Master AAV76.
- Run 8 times per each case.
For  0 key systems, it takes 61 us (IMO, this is most cases).
For  1 key system,  it takes 1.5 ~ 2.3 ms (average: 1.8 ms)
For  2 key systems, it takes 1.6 ~ 4.4 ms (average: 2.4 ms)
For 10 key systems, it takes 2.0 ~ 5.3 ms (average: 2.6 ms)

[mkosiba (inactive), 2014-06-16 14:14:51]

On 2014/06/16 11:05:53, Yuncheol Heo wrote:
>
https://codereview.chromium.org/333003003/diff/1/android_webview/java/src/org...
> File
android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java
> (right):
> 
>
https://codereview.chromium.org/333003003/diff/1/android_webview/java/src/org...
>
android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java:56:
> initializePlatformKeySystem();
> On 2014/06/16 08:38:20, mkosiba wrote:
> > any idea how much time this will add to our startup?
> Did a quick experiment using android.os.SystemClock:
> - Target device/build: New N7, Master AAV76.
> - Run 8 times per each case.
> For  0 key systems, it takes 61 us (IMO, this is most cases).
> For  1 key system,  it takes 1.5 ~ 2.3 ms (average: 1.8 ms)
> For  2 key systems, it takes 1.6 ~ 4.4 ms (average: 2.4 ms)
> For 10 key systems, it takes 2.0 ~ 5.3 ms (average: 2.6 ms)

much appreciated! This overhead is marginal, LGTM.

[xhwang, 2014-06-16 15:58:32]

lgtm % nits

https://codereview.chromium.org/333003003/diff/1/media/base/android/media_drm...
File media/base/android/media_drm_bridge.cc (right):

https://codereview.chromium.org/333003003/diff/1/media/base/android/media_drm...
media/base/android/media_drm_bridge.cc:291: reinterpret_cast<uint8*>(&uuid_lsb +
1));
nit: Can you convert the UUID to an array or vector in Java code so we don't
need all of these in native code?

[ycheo (away), 2014-06-16 21:42:11]

https://codereview.chromium.org/333003003/diff/1/media/base/android/media_drm...
File media/base/android/media_drm_bridge.cc (right):

https://codereview.chromium.org/333003003/diff/1/media/base/android/media_drm...
media/base/android/media_drm_bridge.cc:291: reinterpret_cast<uint8*>(&uuid_lsb +
1));
On 2014/06/16 15:58:32, xhwang wrote:
> nit: Can you convert the UUID to an array or vector in Java code so we don't
> need all of these in native code?

In UUID, there is no method to return an array or vector.
http://developer.android.com/reference/java/util/UUID.html

Is what you want just to move the converting routine from jlong to ByteArray in
Java?

[xhwang, 2014-06-16 21:46:51]

https://codereview.chromium.org/333003003/diff/1/media/base/android/media_drm...
File media/base/android/media_drm_bridge.cc (right):

https://codereview.chromium.org/333003003/diff/1/media/base/android/media_drm...
media/base/android/media_drm_bridge.cc:291: reinterpret_cast<uint8*>(&uuid_lsb +
1));
On 2014/06/16 21:42:11, Yuncheol Heo wrote:
> On 2014/06/16 15:58:32, xhwang wrote:
> > nit: Can you convert the UUID to an array or vector in Java code so we don't
> > need all of these in native code?
> 
> In UUID, there is no method to return an array or vector.
> http://developer.android.com/reference/java/util/UUID.html
> 
> Is what you want just to move the converting routine from jlong to ByteArray
in
> Java? 

Yes, I saw that, so you have to do some kind of convertion. I meant, in stead of
converting it here, can we do it in Java?

[ycheo (away), 2014-06-16 21:57:54]

On 2014/06/16 21:46:51, xhwang wrote:
>
https://codereview.chromium.org/333003003/diff/1/media/base/android/media_drm...
> File media/base/android/media_drm_bridge.cc (right):
> 
>
https://codereview.chromium.org/333003003/diff/1/media/base/android/media_drm...
> media/base/android/media_drm_bridge.cc:291: reinterpret_cast<uint8*>(&uuid_lsb
+
> 1));
> On 2014/06/16 21:42:11, Yuncheol Heo wrote:
> > On 2014/06/16 15:58:32, xhwang wrote:
> > > nit: Can you convert the UUID to an array or vector in Java code so we
don't
> > > need all of these in native code?
> > 
> > In UUID, there is no method to return an array or vector.
> > http://developer.android.com/reference/java/util/UUID.html
> > 
> > Is what you want just to move the converting routine from jlong to ByteArray
> in
> > Java? 
> 
> Yes, I saw that, so you have to do some kind of convertion. I meant, in stead
of
> converting it here, can we do it in Java?

got it. I'll try to convert it to ByteBuffer.

[ycheo (away), 2014-06-16 23:40:37]

https://codereview.chromium.org/333003003/diff/1/media/base/android/media_drm...
File media/base/android/media_drm_bridge.cc (right):

https://codereview.chromium.org/333003003/diff/1/media/base/android/media_drm...
media/base/android/media_drm_bridge.cc:291: reinterpret_cast<uint8*>(&uuid_lsb +
1));
On 2014/06/16 21:46:50, xhwang wrote:
> On 2014/06/16 21:42:11, Yuncheol Heo wrote:
> > On 2014/06/16 15:58:32, xhwang wrote:
> > > nit: Can you convert the UUID to an array or vector in Java code so we
don't
> > > need all of these in native code?
> > 
> > In UUID, there is no method to return an array or vector.
> > http://developer.android.com/reference/java/util/UUID.html
> > 
> > Is what you want just to move the converting routine from jlong to ByteArray
> in
> > Java? 
> 
> Yes, I saw that, so you have to do some kind of convertion. I meant, in stead
of
> converting it here, can we do it in Java?

Done.

[xhwang, 2014-06-17 04:26:43]

lgtm++

[ycheo (away), 2014-06-17 07:47:44]

The CQ bit was checked by ycheo@chromium.org

[commit-bot: I haz the power, 2014-06-17 07:49:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ycheo@chromium.org/333003003/40001

[commit-bot: I haz the power, 2014-06-17 11:59:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-17 11:59:34]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)

[ycheo (away), 2014-06-18 04:17:32]

The CQ bit was checked by ycheo@chromium.org

[commit-bot: I haz the power, 2014-06-18 04:19:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ycheo@chromium.org/333003003/60001

[commit-bot: I haz the power, 2014-06-18 10:44:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-18 10:44:39]

Try jobs failed on following builders:
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[ycheo (away), 2014-06-18 10:52:56]

@mkosiba,

I added 'media/base/android/java' into android_webview/java/DEPS to pass
'checkdeps' stage.
Do you think it's OK?

[ycheo (away), 2014-06-18 21:14:41]

The CQ bit was checked by ycheo@chromium.org

[commit-bot: I haz the power, 2014-06-18 21:16:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ycheo@chromium.org/333003003/80001

[commit-bot: I haz the power, 2014-06-19 00:58:49]

Change committed as 278207

[boliu, 2014-06-19 16:54:33]

https://codereview.chromium.org/333003003/diff/80001/android_webview/test/she...
File android_webview/test/shell/res/values/config.xml (right):

https://codereview.chromium.org/333003003/diff/80001/android_webview/test/she...
android_webview/test/shell/res/values/config.xml:11:
<item>"com.oem.test-keysystem,EDEF8BA9-79D6-4ACE-A3C8-27DCD51D21ED"</item>
This is breaking webview downstream which does resources a bit differently. Do
you have the downstream side patch ready? Is it ok to re-use/release with this
key?