Implemented analysis.setPrioritySource

pkg/analysis_server/lib/src/analysis_server.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analysis.server;
 
 import 'dart:async';
 import 'dart:collection';
 
 import 'package:analysis_server/src/analysis_logger.dart';
@@ skipping 129 matching lines @@
     operationQueue = new ServerOperationQueue(this);
     contextDirectoryManager = new AnalysisServerContextDirectoryManager(this, resourceProvider);
     AnalysisEngine.instance.logger = new AnalysisLogger();
     running = true;
     Notification notification = new Notification(SERVER_CONNECTED);
     channel.sendNotification(notification);
     channel.listen(handleRequest, onDone: done, onError: error);
   }
 
   /**
+   * Schedules execution of the given [ServerOperation].
+   */
+  void scheduleOperation(ServerOperation operation) {
+    bool wasEmpty = operationQueue.isEmpty;
+    addOperation(operation);
+    if (wasEmpty) {
+      _schedulePerformOperation();
+    }
+  }
+
+  /**
    * Schedules analysis of the given context.
    */
   void schedulePerformAnalysisOperation(AnalysisContext context) {
     scheduleOperation(new PerformAnalysisOperation(context, false));
   }
 
   /**
-   * Schedules execution of the given [ServerOperation].
+   * Send the given [notification] to the client.
    */
-  void scheduleOperation(ServerOperation operation) {
-    bool wasEmpty = operationQueue.isEmpty;
-    addOperation(operation);
-    if (wasEmpty) {
-      _schedulePerformOperation();
-    }
+  void sendNotification(Notification notification) {
+    channel.sendNotification(notification);
   }
 
   /**
+   * Set the priority files to the given [files].
+   */
+  void setPriorityFiles(Request request, List<String> files) {

[Paul Berry, 2014/06/16 23:43:16]

I don't think this algorithm will do the right thing when the set of priority
sources for a given context drops to zero.  For example, consider this sequence
of commands:

- setPriorityFiles(['ctx1/foo.dart', 'ctx2/bar.dart'])
  - causes ctx1's priority order to be set to ['ctx1/foo.dart'] and ctx2's
priority order to be set to ['ctx2/bar.dart']
- setPriorityFiles(['ctx2/bar.dart', 'ctx2/baz.dart'])
  - causes ctx2's priority order to be set to ['ctx2/bar.dart', 'ctx2/baz.dart']
  - fails to clear ctx1's priority order
- setPriorityFiles([])
  - fails to clear ctx2's priority order

[Brian Wilkerson, 2014/06/17 17:46:16]

Good catch! Thanks!

+    Map<AnalysisContext, List<Source>> sourceMap =
+        new HashMap<AnalysisContext, List<Source>>();
+    List<String> unanalyzed = new List<String>();
+    files.forEach((file) {
+      AnalysisContext analysisContext = _getAnalysisContext(file);
+      if (analysisContext == null) {
+        unanalyzed.add(file);
+      } else {
+        List<Source> sourceList = sourceMap[analysisContext];
+        if (sourceList == null) {
+          sourceList = <Source>[];
+          sourceMap[analysisContext] = sourceList;
+        }
+        String uri = new Uri.file(file).toString();
+        Source source = analysisContext.sourceFactory.forUri(uri);
+        sourceList.add(source);
+      }
+    });
+    if (unanalyzed.isNotEmpty) {
+      StringBuffer buffer = new StringBuffer();
+      buffer.writeAll(unanalyzed, ', ');
+      throw new RequestFailure(new Response.unanalyzedPriorityFiles(request,
+          buffer.toString()));
+    }
+    sourceMap.forEach((AnalysisContext context, List<Source> sourceList) {
+      context.analysisPriorityOrder = sourceList;
+    });
+  }
+
+  /**
    * Adds the given [ServerOperation] to the queue, but does not schedule
    * operations execution.
    */
   void addOperation(ServerOperation operation) {
     operationQueue.add(operation);
   }
 
   /**
    * The socket from which requests are being read has been closed.
    */
@@ skipping 226 matching lines @@
   }
 
   /**
    * Return `true` if all operations have been performed in this [AnalysisServer].
    */
   bool test_areOperationsFinished() {
     return operationQueue.isEmpty;
   }
 
   /**
-   * Send the given [notification] to the client.
-   */
-  void sendNotification(Notification notification) {
-    channel.sendNotification(notification);
-  }
-
-  /**
    * Schedules [performOperation] exection.
    */
   void _schedulePerformOperation() {
     new Future(performOperation);
   }
 }
 
 
 /**
  * An enumeration of the services provided by the analysis domain.
@@ skipping 58 matching lines @@
 /**
  * An enumeration of the services provided by the server domain.
  */
 class ServerService extends Enum2<ServerService> {
   static const ServerService STATUS = const ServerService('STATUS', 0);
 
   static const List<ServerService> VALUES = const [STATUS];
 
   const ServerService(String name, int ordinal) : super(name, ordinal);
 }